Skip to content

Commit

Permalink
v1.3.4.2
Browse files Browse the repository at this point in the history
- When renaming Transfer-Encoding/Chunk-Encoding headers, set Content-Length to enhance AutoResponder playback
- Update info link to point to my blog
- Update copyright to 2023
  • Loading branch information
ericlaw1979 committed Jan 4, 2023
1 parent 36e0e52 commit f8a3065
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 6 deletions.
4 changes: 2 additions & 2 deletions FiddlerImportNetlog/FiddlerInterface.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

namespace FiddlerImportNetlog
{
[ProfferFormat("NetLog JSON",
"Chromium's JSON-based event log format (v1.3.4.1). See https://dev.chromium.org/for-testers/providing-network-details for more details.",
[ProfferFormat("NetLog JSON",
"Chromium's JSON-based event log format (v1.3.4.2). See https://textslashplain.com/2020/01/17/capture-network-logs-from-edge-and-chrome/ for more info.",
// We handle import of JSON files, whether uncompressed, or compressed with ZIP or GZ. I'm not completely sure I remember the implications
// of declaring .gz here, nor why .zip isn't mentioned. Is this about the drag/drop import feature?
".json;.gz"
Expand Down
7 changes: 7 additions & 0 deletions FiddlerImportNetlog/Importer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1538,6 +1538,7 @@ private void BuildAndAddSession(ref SessionFlags oSF, HTTPRequestHeaders oRQH, H
{
oRQH = Fiddler.Parser.ParseRequest(sMethod + " " + sURL + " HTTP/1.1\r\nMissing-Data: Request Headers not captured in NetLog\r\n\r\n");
}

if (msResponseBody.Length < 1 && cbDroppedResponseBody > 0)
{
dictSessionFlags["X-RESPONSEBODYTRANSFERLENGTH"] = cbDroppedResponseBody.ToString("N0");
Expand All @@ -1550,6 +1551,12 @@ private void BuildAndAddSession(ref SessionFlags oSF, HTTPRequestHeaders oRQH, H
// headers so we can use this session for AutoResponder playback, etc.
oRPH.RenameHeaderItems("Content-Encoding", "X-Netlog-Removed-Content-Encoding");
oRPH.RenameHeaderItems("Transfer-Encoding", "X-Netlog-Removed-Transfer-Encoding");
string sOriginalCL = oRPH["Content-Length"];
oRPH["Content-Length"] = msResponseBody.Length.ToString();
if (!String.IsNullOrEmpty(sOriginalCL) && oRPH["Content-Length"] != sOriginalCL)
{
oRPH["X-Netlog-Original-Content-Length"] = sOriginalCL;
}
}

Session oS = Session.BuildFromData(false,
Expand Down
15 changes: 13 additions & 2 deletions FiddlerImportNetlog/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@

[assembly: AssemblyTitle("FiddlerImportNetlog")]
[assembly: AssemblyDescription("Import Chromium NetLog events to Fiddler")]
[assembly: AssemblyCopyright("Copyright ©2021 Eric Lawrence")]
[assembly: AssemblyCopyright("Copyright ©2023 Eric Lawrence")]
[assembly: System.Resources.NeutralResourcesLanguage("en-US")]
[assembly: ComVisible(false)]
[assembly: AssemblyVersion("1.3.4.1")] // ALWAYS UPDATE THE VERSION in the [ProfferFormat] attribute in FiddlerInterface.cs to match!
[assembly: AssemblyVersion("1.3.4.2")] // ALWAYS UPDATE THE VERSION in the [ProfferFormat] attribute in FiddlerInterface.cs to match!
[assembly: Fiddler.RequiredVersion("4.6.0.0")]


Expand All @@ -20,6 +20,17 @@ HTTP_STREAM_JOB has a binding between the request and the socket. Hook them up s
--> source_dependency = 1701 (URL_REQUEST)
*/

// v1.3.4.2
// When renaming Transfer-Encoding/Chunk-Encoding headers, set Content-Length to enhance AutoResponder playback
// Update copyright to 2023

// v1.3.4.1
// Fix parsing of TLS/1.3 sigscheme list

// v1.3.4.0
// Parse certificaterequest message properly on TLS/1.3 connections
// Add smartscreen to net annotations

// v1.3.3.0
// Add ClientHello and ServerHello to SecureSocket list

Expand Down
2 changes: 1 addition & 1 deletion installer/Addon.ver
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.2.3.0
1.3.4.2
2 changes: 1 addition & 1 deletion installer/FiddlerImportNetLog.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ VIProductVersion "${VER_ADDON}"
VIAddVersionKey "FileVersion" "${VER_ADDON}"
VIAddVersionKey "ProductName" "Fiddler NetLog Importer"
VIAddVersionKey "Comments" "https://textslashplain.com/"
VIAddVersionKey "LegalCopyright" "©2019 Eric Lawrence"
VIAddVersionKey "LegalCopyright" "©2023 Eric Lawrence"
VIAddVersionKey "CompanyName" "Eric Lawrence"
VIAddVersionKey "FileDescription" "Installer for Fiddler Fiddler NetLog Importer"

Expand Down

0 comments on commit f8a3065

Please sign in to comment.