Remove temporary files when done #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we leak files like /tmp/tmp* which is
%opt{ansi_command_file}. Remove it at least after the buffer is closed.
The option is buffer scoped but it could be global. Probably we
should just use kak_command_fifo instead of our own temporary file but
apparently some people use Kakoune from 2020 shipped by their Ubuntu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we leak files like /tmp/tmp* which is
%opt{ansi_command_file}. Remove it at least after the buffer is closed.
The option is buffer scoped but it could be global. Probably we
should just use kak_command_fifo instead of our own temporary file but
apparently some people use Kakoune from 2020 shipped by their Ubuntu.