Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use get_ensemble_by_name from LocalStorage #640

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 5, 2024

erts api has been updated such that get_ensemble_by_name is only available via LocalExperiment.

@dafeda dafeda requested review from oyvindeide and removed request for oyvindeide September 5, 2024 07:02
@dafeda dafeda closed this Sep 6, 2024
@dafeda dafeda reopened this Sep 6, 2024
@dafeda dafeda force-pushed the no-get-ensemble-by-name branch from d21d517 to 8d7486c Compare September 6, 2024 07:01
@dafeda dafeda self-assigned this Sep 6, 2024
@larsevj larsevj force-pushed the no-get-ensemble-by-name branch from 8d7486c to 0097006 Compare September 6, 2024 12:11
@larsevj larsevj requested a review from oyvindeide September 6, 2024 12:38
@larsevj
Copy link
Contributor

larsevj commented Sep 6, 2024

Created issue for supporting/requiring an experiment name in ahmanalysisjob: #645

@larsevj
Copy link
Contributor

larsevj commented Sep 6, 2024

Will squash the three latest commits before merging.

@oyvindeide oyvindeide force-pushed the no-get-ensemble-by-name branch from da66e89 to c7307ef Compare September 6, 2024 21:03
Copy link
Contributor

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored by: larsevj <[email protected]>

erts api has been updated such that get_ensemble_by_name
is only available via LocalExperiment.
@oyvindeide oyvindeide force-pushed the no-get-ensemble-by-name branch from c7307ef to adc6f9a Compare September 6, 2024 21:05
@oyvindeide oyvindeide enabled auto-merge (rebase) September 6, 2024 21:05
@oyvindeide oyvindeide merged commit 4ce81a7 into equinor:main Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants