Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require experiment name in AhmAnalysisJob #645

Open
larsevj opened this issue Sep 6, 2024 · 1 comment
Open

Require experiment name in AhmAnalysisJob #645

larsevj opened this issue Sep 6, 2024 · 1 comment
Labels
christmas-review Issues and PRs for Christmas review

Comments

@larsevj
Copy link
Contributor

larsevj commented Sep 6, 2024

To ensure that you choose the correct ensemble in AhmAnalysisJob it should eventually be required to pass in the experiment name in run:

class AhmAnalysisJob(SemeioScript):
    """Define ERT workflow to evaluate change of parameters for eac
    observation during history matching
    """

    def run(
        self,
        target_name="analysis_case",
        prior_name=None,
        group_by="data_key",
        output_dir=None,
    ):
@larsevj
Copy link
Contributor Author

larsevj commented Sep 6, 2024

Also this part uses deprecated features, in AhmAnalysisJob:

        prior_name, target_name = check_names(
            self.ensemble.name,
            prior_name,
            target_name,
        )

@eivindjahren eivindjahren added the christmas-review Issues and PRs for Christmas review label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review Issues and PRs for Christmas review
Projects
Status: No status
Development

No branches or pull requests

2 participants