Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider policy for failing to stop a mission #730

Open
andchiind opened this issue Feb 21, 2025 · 0 comments
Open

Reconsider policy for failing to stop a mission #730

andchiind opened this issue Feb 21, 2025 · 0 comments
Labels
improvement Improvement to existing functionality

Comments

@andchiind
Copy link
Contributor

Describe the improvement you would like to see
Currently we stop missions by moving to the stop state and then we call the robot interface to stop the robot. If we fail to stop the robot we keep trying for N number of times until we give up. Regardless of whether we give up or succeed, the same transition to idle occurs, only with different warning messages. I would like to change this policy so that we only try to stop the mission once (if we keep retrying then the original API call will time out, since we only give a response once we exit the stop state), and that if we fail to stop the mission we should go to either an Error state or Monitor state. If we reenter monitor then we should hopefully receive task statuses indicating that the mission either continued, or that all remaining tasks were cancelled.

How will this change existing functionality?
It will avoid API request timeouts when trying to stop missions, and it will prevent us from entering Idle in an inconsistent state where we are uncertain whether a mission is still ongoing on the robot.

How will this improvement affect the current Threat Model?
N/A

@andchiind andchiind added the improvement Improvement to existing functionality label Feb 21, 2025
@andchiind andchiind added this to the Ready for users milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant