Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 🚑 Fix Workspace Filters #611

Merged
merged 5 commits into from
Apr 29, 2024
Merged

🐛 🚑 Fix Workspace Filters #611

merged 5 commits into from
Apr 29, 2024

Conversation

kjellhaaland
Copy link
Contributor

@kjellhaaland kjellhaaland commented Apr 29, 2024

Short summary

  • Updated dev deps (not done in previous deps update)
  • Fixed bug with workspace filters closing / reloading when toggeling a filter
  • Fixed hover bug.

Link to issue: #609
Upgrade react issue: https://github.com/equinor/lighthouse/issues/583

PR Checklist

  • I have performed a self-review of my own code
  • I have written a short summary of my changes in the PR
  • I have linked related issue to the PR
  • I have bumped the version(s) in the changed package(s)
  • I have bumped the version in workspace-fusion

Tip

You can test your changes on the test-application. You can find it under apps\test-app\src\index.tsx

Caution

⛔ I understand by merging my PR, the changed packages will be published to NPM immediately ⛔

Copy link

Howdy, wanderer🌵🤠🐴,

Seems you've sauntered into our GitHub saloon with a pull request, but it appears you've forgotten to tie your horse to the hitching post. Now, in this town, we don't take kindly to stray requests, and the GitHub corral is no place for them.

I reckon you best mosey on over and link that pull request to an issue, lest you want the winds of open source trouble blowin' your way. I've got my eye on you, stranger, and a stern warning echoes through these digital canyons.

Now, for those who might be new to these parts or sufferin' from a bout of forgetfulness, fear not. I've rustled up a guide that's as handy as a snake in a boot🐍🥾. Take a peek at this guide, and it'll show you the way to tether that pull request like a seasoned rancher🤠.

Don't let the sun set on your unlinked pull request, and remember, in these GitHub lands, the code speaks louder than six-shooters.

Sincerely,
The code patrol👮

@kjellhaaland kjellhaaland changed the title 🐛 🚑 Fix Workspace FIlters 🐛 🚑 Fix Workspace Filters Apr 29, 2024
Copy link

Howdy, wanderer🌵🤠🐴,

Seems you've sauntered into our GitHub saloon with a pull request, but it appears you've forgotten to tie your horse to the hitching post. Now, in this town, we don't take kindly to stray requests, and the GitHub corral is no place for them.

I reckon you best mosey on over and link that pull request to an issue, lest you want the winds of open source trouble blowin' your way. I've got my eye on you, stranger, and a stern warning echoes through these digital canyons.

Now, for those who might be new to these parts or sufferin' from a bout of forgetfulness, fear not. I've rustled up a guide that's as handy as a snake in a boot🐍🥾. Take a peek at this guide, and it'll show you the way to tether that pull request like a seasoned rancher🤠.

Don't let the sun set on your unlinked pull request, and remember, in these GitHub lands, the code speaks louder than six-shooters.

Sincerely,
The code patrol👮

@kjellhaaland kjellhaaland linked an issue Apr 29, 2024 that may be closed by this pull request
@kjellhaaland kjellhaaland self-assigned this Apr 29, 2024
Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjellhaaland kjellhaaland marked this pull request as ready for review April 29, 2024 10:35
Copy link

Howdy, partner,

Looks like you've got yourself a proper roundup with a posse of packages📦. If you're fixin' to bring 'em into your code corral, just hitch 'em up one by one with a trusty command like a cowboy tamin' a wild mustang.

pnpm i @equinor/[email protected]
pnpm i @equinor/[email protected]
pnpm i @equinor/[email protected]
pnpm i @equinor/[email protected]
pnpm i @equinor/[email protected]
pnpm i @equinor/[email protected]

These here commands will have your packages saddled up and ready to hit the open range of your project. Keep those dependencies roped and ride on into the sunset of seamless coding.

Happy trailblazin'

@kjellhaaland kjellhaaland added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit c609603 Apr 29, 2024
9 checks passed
@kjellhaaland kjellhaaland deleted the 609-workspace-filters branch April 29, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛: Workspace: Filters dissapears when checking boxes
2 participants