-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁: Implemented Report access information #585
Merged
kjellhaaland
merged 6 commits into
main
from
551-pbi-wrapper-custom-access-denied-message
Feb 16, 2024
Merged
🎁: Implemented Report access information #585
kjellhaaland
merged 6 commits into
main
from
551-pbi-wrapper-custom-access-denied-message
Feb 16, 2024
+19
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated exisitng error component to show report and access information when the user does not have access to the report. Added avatar for the person responsible for the report. Added new prop for pbi reports, that provides the dialog with information.
1 task
packages/power-bi/src/lib/components/error/ReportErrorMessage.tsx
Outdated
Show resolved
Hide resolved
Removed deps to fusion libraries Implemented fallback component handler to report error boundary.
@Gustav-Eikaas, this fix now introduces a breaking change.
|
Gustav-Eikaas
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
Bump majors yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PowerBI Component to support showing more information related to report access when the user does not have access to the report.
Implements: #551