Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁: Implemented Report access information #585

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

kjellhaaland
Copy link
Contributor

@kjellhaaland kjellhaaland commented Feb 13, 2024

Updated PowerBI Component to support showing more information related to report access when the user does not have access to the report.

  • Added avatar for the person responsible for the report.
  • Added report general description
  • Added report access description.
  • Added new prop for PBI reports, that provides the dialog with information.

Implements: #551

kjellhaaland and others added 2 commits February 13, 2024 15:18
Updated exisitng error component to show report and access information
when the user does not have access to the report.
Added avatar for the person responsible for the report.

Added new prop for pbi reports, that provides the dialog with
information.
@kjellhaaland kjellhaaland self-assigned this Feb 13, 2024
@kjellhaaland kjellhaaland marked this pull request as ready for review February 13, 2024 14:25
@kjellhaaland kjellhaaland linked an issue Feb 13, 2024 that may be closed by this pull request
1 task
@kjellhaaland
Copy link
Contributor Author

kjellhaaland commented Feb 15, 2024

@Gustav-Eikaas, this fix now introduces a breaking change.
Should i follow semver and bump to the following?

  • @equinor/workspace-powerbi from 1.0.16 to 2.0.0
  • @equinor/workspace-fusion from 7.0.6 to 8.0.0

Copy link
Contributor

@Gustav-Eikaas Gustav-Eikaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!
Bump majors yes

@kjellhaaland kjellhaaland added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit 3d84106 Feb 16, 2024
7 checks passed
@kjellhaaland kjellhaaland deleted the 551-pbi-wrapper-custom-access-denied-message branch February 16, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎁: PBI wrapper - Custom Access denied message
2 participants