Conversation
🦋 Changeset detectedLatest commit: f62e305 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eikeland
marked this pull request as ready for review
September 18, 2026 13:37
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the manifest/lockfile mismatch and add the requested README documentation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes the dev portal ContextSelector so application-driven context changes display correctly without a refresh.
Changes:
- Synchronizes selected and empty preview states.
- Removes document-wide reset behavior.
- Adds regression coverage and updates Vitest configuration.
- Adds the workspace dependency adjustment and patch changeset.
File summaries
| File | Summary |
|---|---|
packages/dev-portal/vitest.config.ts |
Updates test dependency configuration. |
packages/dev-portal/src/ContextSelector/ContextSelector.tsx |
Synchronizes context preview state. Nit: document the user-facing behavior in the package README. |
packages/dev-portal/src/ContextSelector/ContextSelector.test.tsx |
Adds regression tests for updates, clearing, failures, and isolation. |
packages/dev-portal/package.json |
Changes the workspace dependency specifier. Critical: the checked-in lockfile still has the previous specifier. |
.changeset/dev-portal_current-context-preview.md |
Adds patch release notes. |
Review details
Suppressed comments (1)
packages/dev-portal/src/ContextSelector/ContextSelector.tsx:28
- Because this changes user-visible behavior of the published dev portal, please also update
packages/dev-portal/README.mdto document that application- and route-loader-driven context changes update the selector without a refresh. The repository contributor policy requires package README updates for user-facing changes, and the current README only says the selector is wired to the app context, so this behavior is not discoverable to consumers.
* Programmatic context changes, including `setCurrentContextByIdAsync` in route
* loaders, update the preview through the same prop as the empty state, avoiding
* document-wide clear events that can overwrite newer previews.
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the dev portal's ContextSelector where the current context was not displayed correctly after being set with
setCurrentContext. The following changes were made:Additionally, all tests have been verified to pass, and the build process completed successfully. The changes ensure that the context is displayed correctly without requiring a refresh in the app's navigation flow.