Issue 1063: change default guicursor behavior #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some slight hesitancy on check-in for this fix, some users could complain of the exact opposite. However, the TUI behaves as called out in the bug, so perhaps this will not be an issue? |
jgehrig
force-pushed
the
jg-1063-default-guicursor
branch
from
92108a5
to
4a911fa
Compare
Currently, when no guicursor value is provided (styling is disabled), we use some default values: block, ver25, or hor25 based on mode. The TUI does not behave the same way, it uses block mode for all cases when guicursor is empty. This change removes the cursor defaults, and applies block mode to all cases where guicursor is empty.
I think that also matches Vim. If the OS provides an API for "cursor style preferences", that would be ideal. Otherwise, yes, if the user explicitly unsets 'guicursor' they are asking for "do as little as possible". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1063: can't disable cursor styling
Currently, when no guicursor value is provided (styling is disabled), we use some default values: block, ver25, or hor25 based on mode.
The TUI does not behave the same way, it uses block mode for all cases when guicursor is empty.
This change removes the cursor defaults, and applies block mode to all cases where guicursor is empty.