-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #64: Add vignette explaining models #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice @parksw3 and personally I am pretty happy with it as is if you are? The only thing missing from this for me is to update the news file and the pkgdown yaml (so that this is listed on the package website). In a follow issue I guess we need to link to this new vignette from elsewhere in the package?
I think there's just a bit more I want to edit/add. I'll do that towards the end of this week alongside updating the news file and the pkgdown yaml. |
Sorry, it took me longer than I expected to get to this. I tweaked the text very tiny bit and added the new file to package yaml. Am happy with it as is. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 94.38% 94.38%
=======================================
Files 17 17
Lines 837 837
=======================================
Hits 790 790
Misses 47 47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks good to me. I fixed the linting issues, added some fluff text, checked some grammar, and removed the commented out code.
Description
This PR closes #64.
Adds a model write up vignette for the naive and latent models.
Checklist