Issue #981: Convert as_forecast_ to s3

[seabbs]

Description

This PR closes #981

Checklist

• My PR is based on a package issue and I have explicitly linked it.
• I have included the target issue or issues in the PR title as follows: issue-number: PR title
• I have tested my changes locally.
• I have added or updated unit tests where necessary.
• I have updated the documentation if required.
• I have built the package locally and run rebuilt docs using roxygen2.
• My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
• I have added a news item linked to this PR.
• I have reviewed CI checks for this PR and addressed them as far as I am able.

[nikosbosse]

Nice! 2 thoughts:

• as_forecast_binary is missing "default method", i.e. The input needs to be a data.frame or similar for the default method (it's a bit annoying that gh doesn't allow you to suggest changes for old code)
• we could just make all methods .data.frame rather than default. My intuition is that would be cleaner, but not a hill I'm going to die on

[nikosbosse]

oh. Argh. That was an auto-merge branch :P

[nikosbosse]

[seabbs]

we could just make all methods .data.frame rather than default. My intuition is that would be cleaner, but not a hill I'm going to die on

I think you need a default method but yeah could update to have that dispatch to the data.frame method. IMO this would be its own PT as this was just making sure everything was the sabe i.e had a default method.

[seabbs]

is missing "default method",

i.e. you mean docs for it? I think the docs are creaking a bit for these methods

[nikosbosse]

i.e. you mean docs for it? I think the docs are creaking a bit for these methods

yeah just meant that for all other methods you added the clarifying words "default method", but not the binary function.

I think you need a default method but yeah could update to have that dispatch to the data.frame method. IMO this would be its own PT as this was just making sure everything was the sabe i.e had a default method.

I'll open an issue