Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add transition between docs pages, remove scrollToTop. #4431

Merged

Conversation

Sadnessa
Copy link
Contributor

Description

Changing between pages using sidebar visually looked awful, so I decided to add transitions.
Also, I found out and fixed an issue with additional scrolling after a click on sidebar element.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Copy link

netlify bot commented Nov 18, 2024

👷 Deploy request for vuestic-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 959e5a5

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for vuestic-storybook ready!

Name Link
🔨 Latest commit 959e5a5
🔍 Latest deploy log https://app.netlify.com/sites/vuestic-storybook/deploys/673aaef4859f48000875be47
😎 Deploy Preview https://deploy-preview-4431--vuestic-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m0ksem m0ksem changed the title fix: add transition between docs pages, remove scrollToTop. fix(docs): add transition between docs pages, remove scrollToTop. Nov 18, 2024
@m0ksem m0ksem merged commit cadd046 into epicmaxco:develop Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants