Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: vaInput component max Length issue(#4052) #4110

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Alisheroffalex
Copy link
Contributor

Closes #4052

There was a typo on maxlength attribute

Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a commit from different PR. This will cause merge conflict later.

Try to:

git reset develop --hard
git cherry-pick 2ad06460999ad6297b022aea5e93c76559f69eb8

This must re-branch this PR from develop.

@@ -226,7 +226,7 @@ export default defineComponent({

const computedInputAttributes = computed(() => ({
...computedChildAttributes.value,
...pick(props, ['type', 'disabled', 'readonly', 'placeholder', 'pattern', 'inputmode', 'minlength', 'maxlength']),
...pick(props, ['type', 'disabled', 'readonly', 'placeholder', 'pattern', 'inputmode', 'minlength', 'maxLength']),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for minLength I think.

Suggested change
...pick(props, ['type', 'disabled', 'readonly', 'placeholder', 'pattern', 'inputmode', 'minlength', 'maxLength']),
...pick(props, ['type', 'disabled', 'readonly', 'placeholder', 'pattern', 'inputmode', 'minLength', 'maxLength']),

Also, would be nice to handle maxlength and minlength for attrs (similar to native input, but it is nice to have, not required)

@Alisheroffalex
Copy link
Contributor Author

@m0ksem can you please check once again if this PR wont cause merge conflict ?

I also fixed minlength attribute typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaInput maxLength not working
2 participants