Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional_info data structure #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove additional_info data structure #88

wants to merge 1 commit into from

Conversation

mj
Copy link

@mj mj commented Jan 18, 2022

Prior to this change esp-knx-ip did not compile for me in Arduino 1.8.19 on macOS Monterey. The build failed with

In file included from /path/to/Project.ino:1:
esp-knx-ip.h:259:17: error: flexible array member in union
  259 |     cemi_addi_t additional_info[];
      |                 ^~~~~~~~~~~~~~~
exit status 1
flexible array member in union

In addition to that the additional_info array does not seem to be actively used anywhere in the code. So all in all this change seems fine to me.

It is not actively used anywhere in the code and causes the build to
fail in the latest Arduino IDE vor NodeMCU v1.
@IonasElate
Copy link

Great solution. i was running into the same difficulties and manually commented the lines out you highlighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants