Feat: support OpenTofu #185
Conversation
TomerHeber
commented
Feb 1, 2024
•
TomerHeber
commented
- Removed version check. (Not required).
- Defaults to opentofu if "tofu" executable is found.
- Wording changes.
- Integration test for opentofu latest.
| @@ -23,7 +23,6 @@ type TaggingArgs struct { | |||
| IsSkipTerratagFiles bool | |||
| Rename bool | |||
| IACType IACType | |||
| TFVersion Version | |||
There was a problem hiding this comment.
version was required for 0.11 - terratag no longer support 0.11
| newTagsValue = "merge( " + existingTagsExpression + ", " + terratagAddedKey + ")" | ||
| } | ||
|
|
||
| if args.TfVersion.Major == 0 && args.TfVersion.Minor == 11 { |
internal/tfschema/tfschema.go
Outdated
| cmd := exec.Command("terraform", "providers", "schema", "-json") | ||
| // Use tofu by default (if it exists). | ||
| name := "terraform" | ||
| if _, err := exec.LookPath("tofu"); err == nil { |
There was a problem hiding this comment.
this was broken for cases where only tofu was installed.
currently always defaults to tofo is exists.
May want to make it configurable (?) - not sure...
There was a problem hiding this comment.
can you elaborate? broken how? make what configurable?
There was a problem hiding this comment.
you mean that as long as tofu is installed - this would resolve to it, even if someone specifies defaultToTerraform? or did you mean something else
There was a problem hiding this comment.
broken if only tofu was installed and not terraform. (Terratag would not work).
The comment is outdated. If someone uses defaultToTerraform it will default to terraform. I had written this comment before adding 'defaultToTerraform'.
There was a problem hiding this comment.
and what happens if only tofu is installed, and defaultToTerraform isn't provided?
There was a problem hiding this comment.
it will use tofu.
- If only terraform is installed - use terraform.
- if only tofu is installed - use tofu.
- If both terraform and opentofu are installed - use tofu.
- If both terraform and opentofu are installed and default terraform is provided - use terraform.
There was a problem hiding this comment.
before the fix it will always use "terraform" which is a bug if only opentofu is installed.
I don't think there are any bugs after the fix.
| @@ -71,6 +71,31 @@ func TestTerraformlatest(t *testing.T) { | |||
| testTerraform(t, "latest") | |||
| } | |||
|
|
|||
| func TestOpenTofu(t *testing.T) { | |||
There was a problem hiding this comment.
integration test for latest opentofu.
