add a clock based on the notification server's timestamp to status bar #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 27, 2017 00:46
...instead of at the beginning, where WiFi is usually not ready
this allows us to immediately pull notifications
janisstreib
reviewed
May 27, 2017
| @@ -284,11 +288,18 @@ void setup() { | |||
| String wifiLightConf = getConfig("wifilight", "255"); | |||
| wifiLight = atoi(wifiLightConf.c_str()); | |||
| ennotif = getConfig("ennotif", "on") == "on"; | |||
|
|
|||
| int waitforwifi=0; | |||
| while(WiFi.status()!=WL_CONNECTED && waitforwifi++<10) delay(500); | |||
There was a problem hiding this comment.
Why busy waiting? The badge should also work without WiFi...
There was a problem hiding this comment.
Yes,there is probably a better way to do what I wanted to do.
Currently, it takes five minutes until the first poll is done. With this change, it is done immediately at startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires entropia/gpn17-badge-ui#1