Followup improvements to the license review tool #9895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
radeusgd
requested review from
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
radeusgd
commented
May 9, 2024
| import org.enso.build.BenchTasks.* | ||
| import org.enso.build.BenchTasks._ |
There was a problem hiding this comment.
Reverting the * as requested by @hubertp, sorry the PR took so long
radeusgd
commented
May 9, 2024
Comment on lines
+129
to
+136
| // The configuration is not related to any known package, so we remove it | ||
| IO.delete(p) | ||
| Diagnostic.Warning( | ||
| s"Found legal review configuration for package ${p.getName}, but " + | ||
| s"no such dependency has been found. It seems that the " + | ||
| s"dependency has been removed, so the configuration has been " + | ||
| s"deleted. If you think this was mistake, please rely on " + | ||
| s"version control to bring it back." |
There was a problem hiding this comment.
@JaroslavTulach per your request - if I could not match a bumped version which could be renamed from the GUI, we assume the dependency was removed and automatically delete the obsolete directory.
The warning is emitted to let the user know but it's a Warning not Error so it does not fail the report check.
jdunkerley
approved these changes
May 9, 2024
hubertp
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Standard.AWSlibrary #9782Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.