Importing (some of) Standard.Base works from NI runner #9866
Conversation
…erge-dir=./engine/runner/src/main/resources/META-INF/native-image/org/enso/runner" enso --run test/Base_Tests/
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
added
the
CI: Clean build required
|
Are you going to experiment with other standard libraries, like |
If this PR gets green, I'd like to integrated it as it improves the usability a lot. However I don't claim this is a fix for #9774. The work will continue. I still want to create a
Ideally, when we train the native image agent on
Now we have |
All's well including Factorial.enso invocation with regular NI runner, but... there is a failure of Factorial.enso invocation with Espresso built NI runner. Looks like our Espresso support in NI is broken. |
…run without java.desktop
| */ | ||
| package org.yaml.snakeyaml.introspector; | ||
|
|
||
| // remove once https://github.com/snakeyaml/snakeyaml/pull/12 gets integrated |
There was a problem hiding this comment.
Remove this file once snakeyaml/snakeyaml#12 gets integrated.
There was a problem hiding this comment.
E.g. when upgrading to SnakeYaml 2.3 to be released in ~August. Tracked as
| fac number | ||
| main number=5 = | ||
| v = fac number | ||
| IO.println v |
There was a problem hiding this comment.
Using Standard.Base library calls like IO.println
|
The important parts of this PR are green. Let's get ready for the integration.
We have experimentally demonstrated compiling |
There was a problem hiding this comment.
I don't like the changes in sbt. It very much doesn't feel like sbt'ish (not your fault) and adding some shell scripts into the project directory does not help things.
Also, what I'm missing in the source code comments (or build documentation) is the concrete command on how to generate all native image config files. I know that can be found somehow via NI documentation but I'd like to reduce friction points.
- ditch bash script in favour of platform agnostic solution - use proper dependencies between tasks to avoid dummy function calls
There was a problem hiding this comment.
I had a go at SBT and the changes are now in a more acceptable state. I know that the previous solution worked but the build setup easily starts to become a spaghetti monster when one starts to add random bash scripts.
@JaroslavTulach please add docs with an exact command on how to regenerate NI configs.
| ) | ||
| } | ||
|
|
||
| val exec = |
There was a problem hiding this comment.
Exec in Scala! Amazing, thank you @hubertp!
Thank you Hubert.
This commit contains the information 8cc1b2d |
Pull Request Description
Standard.Baseis compiled intorunnerexecutable and canIO.printlnfastenso --run test/Base_Tests.jsonfiles are part of this PRStandard.Baselibrary on-cpwhen building theengine/runner/buildNativeImageENSO_JAVA=espresso ./runnerworking again by avoidingjava.desktopviajlinkChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
Standard.Baselibrary