Skip to content

Conversation

@kazcw
Copy link
Contributor

@kazcw kazcw commented Jan 26, 2026

Fix substituteQualifiedName (currently used to simplify names in dropdown widgets).

substituteQualifiedName had two bugs:

  • It was incorrectly using the return value of Ast.replaceValue, using the value removed from the module as if it were the new tree.
  • It was matching names that are textual prefixes of other names.

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

substituteQualifiedName had two bugs:
- It was incorrectly using the return value of `Ast.replaceValue`, using the
  value *removed from* the module as if it were the new tree.
- It was matching names that are textual prefixes of other names.
@kazcw kazcw self-assigned this Jan 26, 2026
@kazcw kazcw marked this pull request as ready for review January 26, 2026 14:44
@kazcw kazcw marked this pull request as draft January 26, 2026 15:41
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 26, 2026
@kazcw kazcw marked this pull request as ready for review January 28, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants