Skip to content

Fixing project rename #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

vitvakatu
Copy link
Contributor

@vitvakatu vitvakatu commented Jul 21, 2025

Pull Request Description

Fixes #13531

  • Implemented optimistic update for the renameProject mutation. It is necessary because the tanstack query provides the “displayed” project name, and it takes some time for the query to refetch.
  • Fixed error handling on rename inside the graph editor.
  • Copied nameValidation module from the engine to update the project identifier even if the user entered a non-identifier string.
project-rename.mp4

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@vitvakatu vitvakatu force-pushed the wip/vitvakatu/project-rename-13531 branch 2 times, most recently from debea27 to 8eb2c15 Compare July 22, 2025 12:19
@vitvakatu vitvakatu self-assigned this Jul 22, 2025
@vitvakatu vitvakatu added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug -gui labels Jul 22, 2025
@vitvakatu vitvakatu force-pushed the wip/vitvakatu/project-rename-13531 branch from 8eb2c15 to c5222b4 Compare July 22, 2025 12:52
@vitvakatu vitvakatu marked this pull request as ready for review July 22, 2025 12:52
@jdunkerley jdunkerley added this to the 2025.2 Release milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming Project jumps back to the old name before then renaming to the new name
2 participants