Skip to content

Instrument ascribed expressions #13566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Instrument ascribed expressions #13566

wants to merge 2 commits into from
+163 −6

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jul 18, 2025

Pull Request Description

close #13407

Changelog:

  • update: reattach ids from ascribed expression to the expression so that it can be visible to the instrument.

Important Notes

Visualization of ascribed expression is displayed in gui

2025-07-18-204857_927x568_scrot

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@4e6 4e6 self-assigned this Jul 18, 2025
@4e6 4e6 added CI: No changelog needed Do not require a changelog entry for this PR. -language-server labels Jul 18, 2025
JaroslavTulach
JaroslavTulach approved these changes Jul 19, 2025
View reviewed changes
engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/resolve/TypeSignatures.scala
new MetadataPair(this, Signature(newSig, sig.comment))
)
newTyped
.setLocation(sig.location())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reattaching location, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@4e6 4e6

Labels
-language-server CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No visualization updates when providing an explicit type ascription
2 participants
@4e6 @JaroslavTulach