Right Panel fixes #13557
Merged
Right Panel fixes #13557
+68
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw,
AdRiley,
PabloBuchu,
indiv0 and
somebody1234
as code owners
kazcw
approved these changes
Jul 18, 2025
| isFinite(): boolean { | ||
| return Number.isFinite(this.x) && Number.isFinite(this.y) | ||
| } | ||
|
|
||
| /** TODO: Add docs */ | ||
| /** Change Inf values in vector to 0. */ |
There was a problem hiding this comment.
This method intentionally coerces NaN to 0 as well. I think it's just a matter of adjusting docs.
Suggested change
| /** Change Inf values in vector to 0. */ | |
| /** Change any infinite or non-numeric (e.g. `Infinity` or `NaN`) vector values to `0`. */ |
Frizi
approved these changes
Jul 18, 2025
Comment on lines
+273
to
+278
| const w = viewportElem.value.clientWidth / targetScale.value | ||
| const h = viewportElem.value.clientHeight / targetScale.value | ||
| targetLeftTop.value = rect | ||
| .center() | ||
| .finiteOrZero() | ||
| .sub(new Vec2(w / 2, h / 2)) |
There was a problem hiding this comment.
I've got a little confused for a bit and was about to propose to just use rect.pos instead here, but I see that this wouldn't be correct. Let's drop a comment here explaining that rect might have different aspect ratio than viewport, so we still want to move viewport center to rect center explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #13539
Part of #13222
Screencast.From.2025-07-18.11-04-33.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.