Reduce usages of setModal
#13457
Reduce usages of setModal
#13457
Conversation
… `hidden` prop; remove unnecessary `Portal`s TODO: Fix context menu exit animations
This reverts commit 845bdea.
somebody1234
added
the
CI: No changelog needed
somebody1234
added
the
x-refactor
|
pinging @kazcw for CR of event handling, maybe |
|
E-Hern Lee reports a new STANDUP for the provided date (2025-07-08): Progress: - implement It should be finished by 2025-07-13. |
| React.useEffect(() => { | ||
| if (contextMenuPosition != null) { | ||
| setContextMenuPosition(null) | ||
| } | ||
| }, [contextMenuPosition]) |
There was a problem hiding this comment.
So, every time someone is changing contextMenuPosition, we set it back to null?
There was a problem hiding this comment.
yup - this is only the initial context menu position passed to the context menu. feel free to suggest how i can make that clearer
| </Popover> | ||
| ) | ||
| <AboutModal ref={aboutModalRef} /> |
There was a problem hiding this comment.
It feels a bit like component duplication, doesn't it? IIRC you could even have two about modals displayed at the same time: one through user menu, another through application menu (on macOS)
There was a problem hiding this comment.
you're right - this feels cleaner to me but i do agree that the duplication does feel dirty in a way, it should definitely be possible to deduplicate the component.
There was a problem hiding this comment.
So I assume now, in some next PR, DriveProvider (and CategoryProvider) could be moved to Drive.tsx as written here?
Pull Request Description
setModalPortal/Dialogusage - opening and closing is handled by a new imperative APICmd+Vto not work after navigating to a new directoryImportant Notes
None
Testing Instructions
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.