Check `private` access at resolution, not an invocation #13392

Akirathan · 2025-06-27T16:01:05Z

Pull Request Description

Previously, runtime privacy checking did not respect lexical scope. This change moves the privacy checks into UnresolvedSymbol.resolveFor, where the project of the UnresolvedSymbol's scope is compared to the project where the target function is defined.

In other words, private access is checked at resolution (which happens at runtime, before a method is invoked), not at invocation.

Important Notes

Workarounds introduced in 08b04dd reverted in:

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.
If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.
- If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

…guments

This reverts commit 142fecf. See #13078 (comment)

This reverts commit 1a8f5bc. See #13078 (comment)

See #13078 (comment)

See #13078 (comment).

GregoryTravis

Looks good. Just one question about being able to access a field of a public constructor of a private type.

...ests/src/test/java/org/enso/interpreter/test/privateaccess/PrivateConstructorAccessTest.java

...ion-tests/src/test/java/org/enso/interpreter/test/privateaccess/PrivateMethodAccessTest.java

JaroslavTulach

looks like the names of the test methods are/were incorrect
the title needs a change
- looking at the CI failures, this is not going to be minor
- I suggest one such title
a change log entry might be needed

docs/semantics/encapsulation.md

...e/runtime/src/main/java/org/enso/interpreter/runtime/callable/argument/CallArgumentInfo.java

test/Base_Tests/src/Semantic/Private_Spec.enso

JaroslavTulach · 2025-07-06T02:54:24Z

test/Base_Tests/src/Semantic/Private_Spec.enso

@@ -20,17 +20,14 @@ add_specs spec_builder =
        group_builder.specify "can get on hold of private constructor" <|
            Public_Type.cons . is_nothing . should_be_false

-        group_builder.specify "cannot directly call private constructor" <|
-            Test.expect_panic Private_Access <| Public_Type.cons 42


This test was clearly wrong - calling public static method Public_Type.cons is certainly allowed

again the name of the test was misleading - cons is a method, not a constructor

test/Base_Tests/src/Semantic/Private_Spec.enso

...ion-tests/src/test/java/org/enso/interpreter/test/privateaccess/PrivateMethodAccessTest.java

… call arguments" This reverts commit 78f2b81.

JaroslavTulach · 2025-07-16T08:20:22Z

PrivateCheckDisabledTest is failing with

  INFO ide_ci::program::command: sbt ℹ️ [error] Test org.enso.interpreter.test.privateaccess.PrivateCheckDisabledTest.privateCtorCanBeAccessedWhenPrivateCheckIsDisabled failed: org.graalvm.polyglot.PolyglotException: Private_Access.Error, took 0.042 sec
 INFO ide_ci::program::command: sbt ℹ️ [error]     at <enso>.Main.main(Main.enso:3)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.graalvm.polyglot.Value.execute(Value.java:1047)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.enso.polyglot.Function.execute(Function.scala:19)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.enso.test.utils.ProjectUtils.testProjectRun(ProjectUtils.java:134)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.enso.test.utils.ProjectUtils.testProjectRun(ProjectUtils.java:89)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at org.enso.interpreter.test.privateaccess.PrivateCheckDisabledTest.privateCtorCanBeAccessedWhenPrivateCheckIsDisabled(PrivateCheckDisabledTest.java:37)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
 INFO ide_ci::program::command: sbt ℹ️ [error]     at java.lang.reflect.Method.invoke(Method.java:565)

Meta-Value Manipulation

❌ prevent getting value from private constructor
Expected an error Private_Access but no error occurred, instead got: (Cons 42) (at Base_Tests/src/Semantic/Meta_Spec.enso:109:13-73).
❌ prevent getting value from constructor in private module
Expected an error Private_Access but no error occurred, instead got: (Cons 42) (at Base_Tests/src/Semantic/Meta_Spec.enso:120:13-73).

JaroslavTulach

return back the code that had to be changed to lambdas in #13047
having the access checks in UnresolvedSymbol seems correct
please add .name test

...ion-tests/src/test/java/org/enso/interpreter/test/privateaccess/PrivateMethodAccessTest.java

engine/runtime/src/main/java/org/enso/interpreter/runtime/callable/UnresolvedSymbol.java

JaroslavTulach · 2025-07-16T08:37:08Z

test/Base_Tests/src/Semantic/Private_Spec.enso

-        # allow us to do that easily.
-        # For more info, see https://github.com/enso-org/enso/issues/6729
-        group_builder.specify "can get reference to private constructor, but cannot call it" <|
+        group_builder.specify "can get reference to private constructor, and call it from different project" <|
            cons_fn data = Public_Type.cons data


Where exactly one is getting reference to a private constructor? Shouldn't it be

cons_fn = Public_Type.cons c = Meta.meta cons_fn : Meta.Constructor c.fields . should_equal [] c.declaring_type . should_fail_with Private_Check c.name . should_fail...

? But yeah, maybe that's happening behind the scene anyway.

…ters

…e scope. And not from the scope of the current node.

…ters

Calling private constructor is possible, there is no more private access check at invocation.

… from Java if reference was obtained from public method.

Akirathan added 2 commits June 27, 2025 17:58

Revert 08b04dd

1a8f5bc

Revert d9cc084

142fecf

Akirathan self-assigned this Jun 27, 2025

Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 27, 2025

Akirathan added 3 commits June 30, 2025 20:37

Add minimal reproducer

e721cf5

test calling private method directly or via lambda

9dc390b

Copy projectPrivate property from FunctionSchema when mapping call ar…

78f2b81

…guments

Akirathan mentioned this pull request Jul 1, 2025

.name syntax doesn't work across libraries due to (incorrect) encapsulation #13078

Closed

Akirathan added 4 commits July 1, 2025 13:07

Revert "Revert d9cc084"

6c66ef3

This reverts commit 142fecf. See #13078 (comment)

Revert "Revert 08b04dd"

d23375b

This reverts commit 1a8f5bc. See #13078 (comment)

Private constructor cannot be called via callback.

f28e368

See #13078 (comment)

fmt

8782c0b

Akirathan changed the title ~~Wip/akirathan/13078 private generated getters~~ Minor fixes for private method calls Jul 1, 2025

Akirathan marked this pull request as ready for review July 1, 2025 11:14

Akirathan requested review from 4e6, JaroslavTulach and hubertp as code owners July 1, 2025 11:14

hubertp approved these changes Jul 1, 2025

View reviewed changes

Akirathan added 2 commits July 2, 2025 19:49

Fix the expected evaluation semantics in tests.

3786693

See #13078 (comment).

Update private methods semantics in tests

b72747b

Akirathan requested review from jdunkerley, GregoryTravis and AdRiley as code owners July 3, 2025 12:11

GregoryTravis reviewed Jul 3, 2025

View reviewed changes

...ests/src/test/java/org/enso/interpreter/test/privateaccess/PrivateConstructorAccessTest.java Outdated Show resolved Hide resolved

...ion-tests/src/test/java/org/enso/interpreter/test/privateaccess/PrivateMethodAccessTest.java Outdated Show resolved Hide resolved

GregoryTravis approved these changes Jul 3, 2025

View reviewed changes

Akirathan added 3 commits July 3, 2025 16:55

Shouldn't be possible to access private field

c808400

Remove leftover comment

daa591b

Fix encapsulation.md docs

2098788

JaroslavTulach reviewed Jul 6, 2025

View reviewed changes

JaroslavTulach changed the title ~~Minor fixes for private method calls~~ Check private access at resolution, not an invocation Jul 6, 2025

enso-bot bot mentioned this pull request Jul 7, 2025

Allow -> Column&Any to let Column&Integer thru #13390

Open

JaroslavTulach reviewed Jul 9, 2025

View reviewed changes

...ion-tests/src/test/java/org/enso/interpreter/test/privateaccess/PrivateMethodAccessTest.java Show resolved Hide resolved

Akirathan added 11 commits July 14, 2025 12:36

Revert "Copy projectPrivate property from FunctionSchema when mapping…

289684f

… call arguments" This reverts commit 78f2b81.

Better test name

3685ee6

Better test name

8f1f229

Update docs

ebdb0fd

Add test for calling private static method that was directly imported

3e67857

No private checking in InvokeFunctionNode

d1d4975

Update tests: Private field cannot be accessed

b636594

Private check is inside UnresolvedSymbol

1e884d2

fmt

961a412

Fix expected cons name in test

4f58cbc

Update tests: Private field cannot be accessed

2acd478

JaroslavTulach approved these changes Jul 16, 2025

View reviewed changes

Akirathan added 4 commits July 16, 2025 19:00

Revert 08b04dd

e84da7c

Revert d9cc084

ed3b014

Merge branch 'develop' into wip/akirathan/13078-private-generated-get…

a20a46c

…ters

Add CHANGELOG entry

ce79c7f

Akirathan removed the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 16, 2025

Do not check private access if private check is disabled

3c98205

enso-bot bot mentioned this pull request Jul 17, 2025

Moving polyglot java import handling into EpbLanguage #13483

Merged

3 tasks

Akirathan added 5 commits July 21, 2025 12:13

Private check in UnresolvedSymbol compares project from correct modul…

72ccc50

…e scope. And not from the scope of the current node.

Add test for private check of UnresolvedSymbol

20cdc32

Merge branch 'develop' into wip/akirathan/13078-private-generated-get…

286bfec

…ters

Fix tests in Meta_Spec.

e407dba

Calling private constructor is possible, there is no more private access check at invocation.

Fix test in Private_Spec - it is possible to call private constructor…

89a722e

… from Java if reference was obtained from public method.

Akirathan merged commit ca8c480 into develop Jul 21, 2025
80 checks passed

Akirathan deleted the wip/akirathan/13078-private-generated-getters branch July 21, 2025 16:53

enso-bot bot mentioned this pull request Jul 21, 2025

Handshake timeout exception in Azure.list_blob #13462

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Check `private` access at resolution, not an invocation #13392

Check `private` access at resolution, not an invocation #13392

Uh oh!

Akirathan commented Jun 27, 2025 •

edited

Loading

Uh oh!

GregoryTravis left a comment

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Jul 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach commented Jul 16, 2025 •

edited

Loading

Uh oh!

JaroslavTulach left a comment

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Jul 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Check private access at resolution, not an invocation #13392

Check private access at resolution, not an invocation #13392

Uh oh!

Conversation

Akirathan commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Important Notes

Checklist

Uh oh!

GregoryTravis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaroslavTulach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Check `private` access at resolution, not an invocation #13392

Check `private` access at resolution, not an invocation #13392

Akirathan commented Jun 27, 2025 •

edited

Loading

JaroslavTulach commented Jul 16, 2025 •

edited

Loading

JaroslavTulach Jul 16, 2025 •

edited

Loading