Less heavyweight jvm-channel by removing dependency on engine-common #13363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
changed the title
JaroslavTulach
commented
Jun 25, 2025
JaroslavTulach
commented
Jun 25, 2025
|
|
||
| /** Configures provided builder via {@link LoggerSetup}. */ | ||
| @Override | ||
| protected final void prepareBuilderForLogging( |
There was a problem hiding this comment.
This method provides the same implementation that was in ContextFactory itself. By leveling it up here we can remove dependencies of org.enso.common on LoggerSetup, etc. All of that is done here.
JaroslavTulach
commented
Jun 25, 2025
|
|
||
| /** | ||
| * Provides implementation of the {@link ContextLoggingConfigurator} for the `engine-common` module. | ||
| */ | ||
| @ServiceProvider(service = ContextLoggingConfigurator.class) |
There was a problem hiding this comment.
@Akirathan, the d82036a wouldn't be necessary, if we configured native image to use --module-path - I know you reported an issue about it, I just cannot find it now...
hubertp
approved these changes
Jun 25, 2025
lib/java/jvm-channel/src/main/java/org/enso/jvm/channel/JVM.java
Outdated
Show resolved
Hide resolved
lib/java/jvm-channel/src/main/java/org/enso/jvm/channel/PosixJVM.java
Outdated
Show resolved
Hide resolved
JaroslavTulach
added
CI: Clean build required
…ng.config in runtime-benchmarks/bench
|
There is supposed to be a failure in engine-common according to the CI: but I don't see the failure in the log and I cannot reproduce it locally! Running
|
|
Jaroslav Tulach reports a new STANDUP for yesterday (2025-06-26): Progress: .
. It should be finished by 2025-06-30.
|
JaroslavTulach
added
the
CI: Ready to merge
|
Jaroslav Tulach reports a new STANDUP for yesterday (2025-06-27): Progress: .
. It should be finished by 2025-06-30.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Continuation of #13356 to make dependencies of dual mode JVM related libraries less heavyweight.
jvm-channelby removing dependency onengine-commonjvm-interopby removing dependency ofengine-commononlogging-*modulesChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,