Using `Channel` to load Java classes #13238

JaroslavTulach · 2025-06-06T17:21:39Z

Pull Request Description

Provides an opt-in implementation to load classes via HotSpot JVM even when running in native image mode
Use --vm.D=polyglot.enso.classLoading option - more detail to turn the mode on
53b2490 creates new jvm-channel module with less dependencies than os-environment has
- just a refactoring of code introduced by Channel connecting two JVM instances #13206
f0cff3d creates a unit test using Channel in a single JVM
Use Channel in jvm-interop project to implement InteropLibrary messages: 9c129de
connect EnsoContext and jvm-interop in e41d046
use the jvm-interop to start HotSpot JVM and load a class if it is not in native image

Pros

the system for interacting with HotSpot JVM is ready
it can execute some Generic_JDBC_Tests

Pending Future Features

logging in the HotSpot JVM isn't configured
there is no GC support - what's allocated stays allocated

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

All code follows the
Scala,
Java,
Unit tests have been written where possible.

github-actions · 2025-06-06T17:22:48Z

✨ GUI Checks Results

Summary

🧹 Prettier: ✅ Passed
🧰 GUI Checks: ❌ Failed
📚 Storybook: ❌ Failed

⚠️ Action Required: Please review the failed checks and fix them before merging.

See individual check results for more details.

…lInJvm13172

JaroslavTulach · 2025-06-17T06:48:37Z

With 4f373cd we can run some of the Generic_JDBC_Tests in the dual JVM mode:

$ ENSO_LAUNCHER=native,-ls,fast sbt
sbt:enso> runEngineDistribution --run test/Generic_JDBC_Tests
11 tests succeeded.
11 tests failed.
0 tests skipped.
0 groups skipped.

…lInJvm13172

…sloading

JaroslavTulach · 2025-06-17T08:25:49Z

I've turned the whole infrastructure into an opt-in feature. I'd like to integrate now. Please review the PR.

Akirathan

OK, let's get this in.

lib/java/jvm-channel/src/main/java/org/enso/jvm/channel/Channel.java

…Test

…lInJvm13172

jdunkerley

approving my little bit!

…slf4j (#13356) - One of the remaining problems in #13238 - was _"logging in the HotSpot JVM isn't configured"_ - which resulted in a lot of printed log messages - by making `persistance` use the default `System.Logger` no messages shall appear - as the default logger is configured to not log `DEBUG` messages by default - moreover the use of `System.Logger` makes `persistance` _3rd party libraries free_ - while the logging behavior of `persistance` in the Enso runtime remains unchanged - because of the bridge that delegates to _slf4j_

JaroslavTulach added 2 commits June 6, 2025 19:17

Separating JVM functionality into own jvm-channel project

53b2490

Unit test using Channel functionality in a single JVM

f0cff3d

JaroslavTulach self-assigned this Jun 6, 2025

JaroslavTulach requested a review from 4e6 as a code owner June 6, 2025 17:21

JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 6, 2025

JaroslavTulach requested review from hubertp and Akirathan as code owners June 6, 2025 17:21

JaroslavTulach marked this pull request as draft June 6, 2025 17:21

enso-bot bot mentioned this pull request Jun 7, 2025

Dual NI + JVM Mode for Loading Libraries #13172

Closed

3 tasks

JaroslavTulach added 5 commits June 9, 2025 09:19

Testing ChannelInSingleJvm in jvm-channel project itself

365d50d

jvm-interop module with dependency on Truffle

837877d

The enso language may not be enabled

701006e

Using Object[] as class argument yield proper AP error

9817a8e

Messages to find out if an object is an array

9c129de

JaroslavTulach linked an issue Jun 9, 2025 that may be closed by this pull request

Dual NI + JVM Mode for Loading Libraries #13172

Closed

3 tasks

JaroslavTulach added 7 commits June 9, 2025 13:49

Access String array elements

2452421

Transfer all primitive types

b96c9ff

Invoke methods on the other objects

dd9287c

Able to invoke BigDecimal.add(BigDecimal) in the other JVM

73f087b

Transfer of any TruffleObject yields OtherJvmObject and backwards

3ed9c4a

Report duplicated registrations

7a4024d

Invoke java.lang.Short.valueOf in the other JVM

44edc03

JaroslavTulach force-pushed the wip/jtulach/ChannelInJvm13172 branch from f1ec084 to 44edc03 Compare June 9, 2025 18:20

JaroslavTulach added 6 commits June 9, 2025 21:03

loadClass yields an exception

0b8c477

LoadClass really throws ClassNotFoundException

ba92d27

Merge remote-tracking branch 'origin/develop' into wip/jtulach/Channe…

cd2e6b4

…lInJvm13172

Provide support for additional PolyglotSymbolResolver extensions

cec892c

Environment is associated with every DistributionManager

cf3309c

Sending messages must be behind @TruffleBoundary

2b58d27

JaroslavTulach added 2 commits June 16, 2025 17:47

Only enter the TruffleClassLoader.ctx() when on slave

e745a10

Encapsulate general problems with other JVM into Truffle exception

4f373cd

JaroslavTulach added 7 commits June 17, 2025 08:49

Merge remote-tracking branch 'origin/develop' into wip/jtulach/Channe…

44efcf3

…lInJvm13172

Opt-in via --vm.D=polyglot.enso.classLoading to enable other JVM clas…

fdc89fb

…sloading

Initialize with null

dc4db1f

Removing non-javadoc documentation

6018f38

Removing commented out requires statements

9ea85e3

A javadoc

22f170c

Using name constants to identify special isolates

e765579

JaroslavTulach requested review from hubertp, Akirathan and vitvakatu June 17, 2025 08:25

Akirathan mentioned this pull request Jun 17, 2025

Use module path in NI to avoid unnecesary dependencies #13293

Open

Akirathan approved these changes Jun 17, 2025

View reviewed changes

lib/java/jvm-channel/src/main/java/org/enso/jvm/channel/Channel.java Show resolved Hide resolved

JaroslavTulach added 2 commits June 17, 2025 14:16

Associate Channel.isMaster with a Context when running OtherJvmObject…

cda3980

…Test

Avoid PolyglotSymbolResolver.addToClassPath until it is turned on

66a2045

JaroslavTulach added CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Jun 17, 2025

JaroslavTulach added 2 commits June 17, 2025 18:29

Merge remote-tracking branch 'origin/develop' into wip/jtulach/Channe…

06d01e5

…lInJvm13172

windows-2019 image is being deprecated

f4b374e

JaroslavTulach requested a review from jdunkerley as a code owner June 17, 2025 16:44

jdunkerley approved these changes Jun 17, 2025

View reviewed changes

Backout of f383a7d

d77b80b

JaroslavTulach merged commit bd1dfc5 into develop Jun 18, 2025
74 of 76 checks passed

JaroslavTulach deleted the wip/jtulach/ChannelInJvm13172 branch June 18, 2025 04:19

enso-bot bot mentioned this pull request Jun 19, 2025

Narrowing a multi-value type to a (>1) subset does not just hide but completely removes the remaining part #13272

Closed

JaroslavTulach mentioned this pull request Jun 24, 2025

Less heavyweight persistance module by bridging System.Logger to slf4j #13356

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Using `Channel` to load Java classes #13238

Using `Channel` to load Java classes #13238

Uh oh!

JaroslavTulach commented Jun 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

JaroslavTulach commented Jun 17, 2025

Uh oh!

JaroslavTulach commented Jun 17, 2025

Uh oh!

Akirathan left a comment

Uh oh!

Uh oh!

jdunkerley left a comment

Uh oh!

Uh oh!

Uh oh!

Using Channel to load Java classes #13238

Using Channel to load Java classes #13238

Uh oh!

Conversation

JaroslavTulach commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Pros

Pending Future Features

Checklist

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ GUI Checks Results

Summary

Uh oh!

JaroslavTulach commented Jun 17, 2025

Uh oh!

JaroslavTulach commented Jun 17, 2025

Uh oh!

Akirathan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jdunkerley left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Using `Channel` to load Java classes #13238

Using `Channel` to load Java classes #13238

JaroslavTulach commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading