Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pair.to Meta.Type . qualified_name fix #12214

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Pair.to Meta.Type . qualified_name fix #12214

wants to merge 1 commit into from
+15 −2

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 1, 2025 •
edited
Loading

Pull Request Description

  • looks like Reducing helper methods in Standard.Base.Meta #12031 changed Meta behavior for qualified names
  • Pair.to Meta.Type . qualified_name is returning "Standard.Base.Data.Pair.Pair.type".
  • Meta.get_qualified_type_name Pair used to return "Standard.Base.Data.Pair.Pair".
  • returning the previous behavior
  • fixing it with a Meta_Spec test
  • adjusting MetaObjectTest to the new behavior

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 1, 2025
@JaroslavTulach JaroslavTulach self-assigned this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JaroslavTulach