Cloud File Browser displays full tree in teams plan. #12208
Conversation
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
There was a problem hiding this comment.
This is a bit of a nitpick, but: I see that isLoading is used to prevent the stack from being observed (or, indirectly, from being racily-modified) while the initialization logic may be navigating to the user's directory. In my opinion it could be more maintainable to keep the intermediate state local to the initial-loading logic, and set the stack state only when the "final" initial value for it has been computed (by adding a parent argument to enterDirByName and adding a wrapper for queryClient.fetchQuery to the useBackend API for this sort of one-shot queries). This way stack would be safe to use any time its value is present, rather than guarding it with another variable.
| ) | ||
|
|
||
| const currentPath = computed(() => { | ||
| if (!currentUser.data.value) return | ||
| let root = backend?.rootPath(currentUser.data.value) |
There was a problem hiding this comment.
Currently the backend == null case should be unreachable here, but I think for clarity and maintainability it's better to check it explicitly than stringify a value that is technically nullable.
|
Applied review, and fixed loading spinner; now, loading sequence looks like this: Screencast.From.2025-02-03.12-12-59.mp4 |
| .LoadingSpinner { | ||
| border: 4px solid; | ||
| border-radius: 100%; | ||
| border-color: rgba(255, 255, 255, 90%) #0000; |
There was a problem hiding this comment.
I had a different border-radius and border-color from the general LoadingSpinner styles here--IMO these values look better for the component icon.
…n/all-files-in-cloud-browser
Pull Request Description
Fixes #12002 with one caveat - we are unable to enter projects dirs, so it was not implemented.
Screencast.From.2025-01-31.16-30-26.mp4
I resigned from displaying project, as I think better UX is without them.
Important Notes
Tested on cloud staging.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.