Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Mac OS X aarch64 version of native lib of opencv #12197

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Jan 30, 2025

Fixes #12178

Pull Request Description

Include Mac OS X aarch64 version of native library in OpenCV. Previously, it was accidentally dropped from the distribution.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 30, 2025
@Akirathan Akirathan self-assigned this Jan 30, 2025
@Akirathan
Copy link
Member Author

Checked on @GregoryTravis 's Mac with ARM64. I hope this fixes the Engine Nightly checks.

Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With clean build

/enso$ rm -rf *; git checkout -f 

I managed to run:

sbt:enso> runEngineDistribution --run test/Image_Tests
174 tests succeeded.op evaluation
0 tests failed.unning  'runEngineDistribution --run test/Image_Tests'
0 tests skipped.o stop evaluation
1 groups skipped.

@Akirathan Akirathan force-pushed the wip/akirathan/fix-mac-opencv branch from c14cf7a to 6554975 Compare February 3, 2025 15:07
@Akirathan Akirathan merged commit 171723a into develop Feb 4, 2025
41 of 44 checks passed
@Akirathan Akirathan deleted the wip/akirathan/fix-mac-opencv branch February 4, 2025 15:16
@Akirathan
Copy link
Member Author

Akirathan commented Feb 5, 2025

NativeLibraryFinderTest now passes on the most recent Engine Nightly Check, as well as testing Image_Tests on Mac aarch64 in https://github.com/enso-org/enso/actions/runs/13149408049/job/36694037270#step:8:3141

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Engine Nightly Checks · 7031afe

hubertp added a commit that referenced this pull request Feb 6, 2025
Breaks Tableau integration to accomadate for opencv non-standard
packaging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard.Image is broken on macos/aarch64
4 participants