Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Widget Fixes #12196

Merged
merged 14 commits into from
Feb 3, 2025
Merged

Table Widget Fixes #12196

merged 14 commits into from
Feb 3, 2025

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jan 30, 2025 •
edited
Loading

Pull Request Description

  • Fix new_text widget for Column.text_replace.
    image
  • Use the default widget for Join_Kind.
    image
  • Added Missing_Argument to right for cross_join.
    image
  • Add new Row_Limit type and use this for right_row_limit on cross_tab. Added conversion for backward compatibility.
    image
  • Add Missing_Argument to lookup_table on Table.merge.
    image
  • Add Missing_Argument to key_columns on Table.merge but thrown when no entries in the vector.
    image
  • Default for add_new_columns switched to True.
  • Columns_To_Keep dropdown shows the .. to be consistent.
    image
  • Missing_Argument for Table.zip.
    image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@jdunkerley
Fix text_replace on Column.
41876d6
@jdunkerley
Fix for expand_column. If empty field array then treat as Nothing.
a5ad572 
Remove Join_Kind widget in favour of default widget.
Add Missing Value for cross_join.
@jdunkerley
Switch right_row_limit to be a Rows_To_Read as this has widget supp…
d0b7328 
…ort.
@jdunkerley
Use a Row_Limit type for cross_join.
c550866
@jdunkerley
merge throws Missing_Value if no lookup_table.
9b6a3f4 
Check for entries
in `key_columns` and throw error if empty.
Change default widget for `Columns_To_Keep` to have the `..`.
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 30, 2025
@jdunkerley jdunkerley marked this pull request as ready for review January 30, 2025 16:37
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jan 30, 2025
@jdunkerley jdunkerley added the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 3, 2025
@mergify mergify bot merged commit 7cbe777 into develop Feb 3, 2025
40 of 44 checks passed
@mergify mergify bot deleted the wip/jd/text_replace_widget branch February 3, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdRiley AdRiley AdRiley approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

@hubertp hubertp Awaiting requested review from hubertp

@Frizi Frizi Awaiting requested review from Frizi

Assignees
No one assigned
Labels
CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdunkerley @AdRiley @GregoryTravis