Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Initially blur currency displayer #247

Conversation

vincius0000
Copy link
Contributor

Fixes #246

@enrique-lozano
Copy link
Owner

enrique-lozano commented Nov 11, 2024

Thanks for the PR! It is a good temporary solution, although in the future I think we should consider keeping the splash screen until all the settings load (and saving them in memory instead of accessing the database all the time we need the value of some setting)

@vincius0000
Copy link
Contributor Author

vincius0000 commented Nov 11, 2024

Thanks for the PR! It is a good temporary solution, although in the future I think we should consider keeping the splash screen until all the settings load (and saving them in memory instead of accessing the database all the time we need the value of some setting)

Sounds like a plan! For in memory storage we could use Shared Preferences

And for Splash screen, it should be fairly easy to implement. Some parts may need refactoring, depending on how easy it is to fetch the status of different services/streams as here we need all services to complete, only then show pages other than Splash screen.

@vincius0000
Copy link
Contributor Author

vincius0000 commented Nov 11, 2024

On second though, there is no need to use Shared Preferences, I've looked at it too difficult 😄

Fetching from db once and storing in memory sounds good, can be done within the service alone.

@enrique-lozano
Copy link
Owner

On second though, there is no need to use Shared Preferences, I've looked at it too difficult 😄

Fetching from db once and storing in memory sounds good, can be done within the service alone.

Exactly!

@enrique-lozano
Copy link
Owner

This should be fixed in #259. Have to test it a little more but seems good already

@vincius0000 vincius0000 deleted the fix/initially-blur-currency branch December 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants