Added support for minimal Markdown "autolinks" #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KABoissonneault
force-pushed
the
feat/autolink
branch
from
caabdbf to
91e7c7b
Compare
KABoissonneault
force-pushed
the
feat/autolink
branch
from
91e7c7b to
3c49421
Compare
|
Thanks we'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, a URL is used both as text and link.
ex:
[https://example.com](https://example.com)The credit section in my "About" markdown has quite a few of them.
The duplication is annoying to do, and makes the Markdown source less readable.
This PR adds support for simple automatic links ("autolinks"). Many Markdown hosts (like Github) simply parse text to recognize URLs, but that would be too complicated for this project. Rather, we use the angle bracket syntax.
Source: https://www.markdownguide.org/basic-syntax/#urls-and-email-addresses
ex:
<https://example.com>This feature has the same restrictions as normal links (no headers, no emphasis), plus no image support (not sure whether it's normally supported or not, but I figure not).
I've also fixed an "unused variable" warning.