Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21 dev #40

Merged
merged 9 commits into from
Jun 24, 2024
Merged

1.21 dev #40

merged 9 commits into from
Jun 24, 2024

Conversation

Oxeus
Copy link

@Oxeus Oxeus commented Jun 21, 2024

Updated the mod to 1.21.

Library Changes:

  • Changed Gradle version to 8.8
  • Loom to 1.7-SNAPSHOT
  • yamlang to '1.3.1
  • yarn_mappings to 1.21+build.2
  • fabric to fabric_version=0.100.3+1.21
  • modmenu to 11.0.0

Code Changes:

  • Fixed issue raised by Shane were packs would not go into correct folders. This involved grabbing the parent folder name when a pack is inside this folder. The parent folder is then checked if or if not it ends with passed in folder.
  • This current fix I couldn't get symbolic links to work.
  • Identifier initialization was changed by Mojang. So "new Identifier" was changed to Identifier.of(). This method does the object creation itself.

Issues:

  • Symbolic Links don't function.
  • Mojang revamped the Ui in recent versions. Available packs is longer than it should be. Buttons in wrong spots and resizing windows messes up positions.

Oxeus added 4 commits June 21, 2024 04:07
Upgraded gradle, loom, and dependencies. Upgraded Fabric and Minecraft Version. Fixed API changes from both Minecraft And Fabric. Fixed an issue where resource packs would not properly load into a folder in game. Partially fixed meta files not reloading, they reload and update when not on main resource pack screen,
Fixed for original parity
fixes to bring back some stuff from 1.20.4
.gitignore Outdated
@@ -25,3 +25,4 @@ bin/
run/

*.ase
/radle-version/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove it I was excluding a folder I renamed while upgrading gradle.

Oxeus added 2 commits June 22, 2024 12:44
Got rid of unused Marker import
Fixed override setup for available and selected back folders. The button and search field are not wanting to obey resizing conventions, this also includes the remade more packs and done buttons. It looks like Mojang has different layout methods that handle these now. The layout can have items added to it though. I disabled these items for know to get the mod in a presentable state with the folder based back structure working.
@Oxeus
Copy link
Author

Oxeus commented Jun 24, 2024

  • I tried for the life of me to take a look at folder meta for symbolic linking but couldn't get anything working on my end.

  • I disabled the folderview/listview button for now, and the search field since they weren't following resizing conventions anymore. It looks like some the mojang ui rework broken the layout.

  • The other two buttons are Resourcify to make sure it's compatible with another resource pack gui mod.

@Oxeus
Copy link
Author

Oxeus commented Jun 24, 2024

2024-06-24_01 32 58
2024-06-24_01 34 15

Oxeus added 3 commits June 24, 2024 01:38
took out random folder.
@enjarai
Copy link
Owner

enjarai commented Jun 24, 2024

Alright, I think this should be good for now then. Anything you still want to finish up or that I should know before merging?

@Oxeus
Copy link
Author

Oxeus commented Jun 24, 2024

I dont't believe so but if anything is wrong it can always be fixed. 👍

@enjarai enjarai merged commit d731860 into enjarai:master Jun 24, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants