Skip to content

Commit

Permalink
Remove deprecated plugins (flutter#4580)
Browse files Browse the repository at this point in the history
This removes all of the deprecated plugins from the tree, as well as all references to them.

They were being left in the tree only in case they needed critical fixes before the end of this year, when they will become completely unsupported and be officially discontinued on pub.dev. The end of the year is now close enough that such a release is extremely unlikely, and they are causing some maintenance burden (e.g., the tree is currently closed on an out-of-band failure in android_alarm_manager). In the event that we do have to push an emergency fix in the next several weeks, we can either temporarily restore the plugin from git history, or use a branch.

Minor related cleanup:
- Scanning the repository for remaining references turned up that `image_picker_for_web` and `video_player_for_web` had copypasta'd the package name of its example application from one of the deprecated plugins, so this fixes those names.
- Fixes `federation-safety-check` handling of top-level files in unfederated plugins that accidentally tripped federated plugin heuristics.
- Fixes `federation-safety-check` handling of deleted plugins, as it was crashing, and tests that.
- Fixes `make-deps-path-based` handling of deleted plugins, as it was crashing, and tests that.
  • Loading branch information
stuartmorgan authored Dec 6, 2021
1 parent 40572a7 commit afc0ad2
Show file tree
Hide file tree
Showing 765 changed files with 108 additions and 29,491 deletions.
4 changes: 2 additions & 2 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ task:
xcode_analyze_script:
- ./script/tool_runner.sh xcode-analyze --ios
native_test_script:
- ./script/tool_runner.sh native-test --ios --ios-destination "platform=iOS Simulator,name=iPhone 11,OS=latest" --exclude=script/configs/exclude_native_ios.yaml
- ./script/tool_runner.sh native-test --ios --ios-destination "platform=iOS Simulator,name=iPhone 11,OS=latest"
drive_script:
# `drive-examples` contains integration tests, which changes the UI of the application.
# This UI change sometimes affects `xctest`.
Expand Down Expand Up @@ -325,6 +325,6 @@ task:
xcode_analyze_script:
- ./script/tool_runner.sh xcode-analyze --macos
native_test_script:
- ./script/tool_runner.sh native-test --macos --exclude=script/configs/exclude_native_macos.yaml
- ./script/tool_runner.sh native-test --macos
drive_script:
- ./script/tool_runner.sh drive-examples --macos
30 changes: 0 additions & 30 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,6 @@
'p: android_alarm_manager':
- packages/android_alarm_manager/**/*

'p: android_intent':
- packages/android_intent/**/*

'p: battery':
- packages/battery/**/*

'p: camera':
- packages/camera/**/*

'p: connectivity':
- packages/connectivity/**/*

'p: cross_file':
- packages/cross_file/**/*

'p: device_info':
- packages/device_info/**/*

'p: espresso':
- packages/espresso/**/*

Expand Down Expand Up @@ -46,9 +28,6 @@
'p: local_auth':
- packages/local_auth/**/*

'p: package_info':
- packages/package_info/**/*

'p: path_provider':
- packages/path_provider/**/*

Expand All @@ -58,12 +37,6 @@
'p: quick_actions':
- packages/quick_actions/**/*

'p: sensors':
- packages/sensors/**/*

'p: share':
- packages/share/**/*

'p: shared_preferences':
- packages/shared_preferences/**/*

Expand All @@ -76,9 +49,6 @@
'p: webview_flutter':
- packages/webview_flutter/**/*

'p: wifi_info_flutter':
- packages/wifi_info_flutter/**/*

'platform-android':
- packages/*/*_android/**/*
- packages/**/android/**/*
Expand Down
9 changes: 0 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,6 @@ Additional resources specific to the plugins repository:
for more information about how to make PRs for this repository, especially when
changing federated plugins.

## Important note

As of January 2021, we are no longer accepting non-critical PRs for the
[deprecated plugins](./README.md#deprecated), as all new development should
happen in the Flutter Community Plus replacements. If you have a PR for
something other than a critical issue (crashes, build failures, security issues)
in one of those pluigns, please [submit it to the Flutter Community Plus
replacement](https://github.com/fluttercommunity/plus_plugins/pulls) instead.

## Other notes

### Style
Expand Down
17 changes: 0 additions & 17 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,20 +59,3 @@ These are the available plugins in this repository.
| [url_launcher](./packages/url_launcher/) | [![pub package](https://img.shields.io/pub/v/url_launcher.svg)](https://pub.dev/packages/url_launcher) | [![pub points](https://badges.bar/url_launcher/pub%20points)](https://pub.dev/packages/url_launcher/score) | [![popularity](https://badges.bar/url_launcher/popularity)](https://pub.dev/packages/url_launcher/score) | [![likes](https://badges.bar/url_launcher/likes)](https://pub.dev/packages/url_launcher/score) |
| [video_player](./packages/video_player/) | [![pub package](https://img.shields.io/pub/v/video_player.svg)](https://pub.dev/packages/video_player) | [![pub points](https://badges.bar/video_player/pub%20points)](https://pub.dev/packages/video_player/score) | [![popularity](https://badges.bar/video_player/popularity)](https://pub.dev/packages/video_player/score) | [![likes](https://badges.bar/video_player/likes)](https://pub.dev/packages/video_player/score) |
| [webview_flutter](./packages/webview_flutter/) | [![pub package](https://img.shields.io/pub/v/webview_flutter.svg)](https://pub.dev/packages/webview_flutter) | [![pub points](https://badges.bar/webview_flutter/pub%20points)](https://pub.dev/packages/webview_flutter/score) | [![popularity](https://badges.bar/webview_flutter/popularity)](https://pub.dev/packages/webview_flutter/score) | [![likes](https://badges.bar/webview_flutter/likes)](https://pub.dev/packages/webview_flutter/score) |

### Deprecated

The following plugins are also part of this repository, but are deprecated in
favor of the [Flutter Community Plus](https://plus.fluttercommunity.dev/) versions.

| Plugin | Pub | | Replacement | Pub |
|--------|-----|--|-------------|-----|
| [android_alarm_manager](./packages/android_alarm_manager/) | [![pub package](https://img.shields.io/pub/v/android_alarm_manager.svg)](https://pub.dev/packages/android_alarm_manager) | | android_alarm_manager_plus | [![pub package](https://img.shields.io/pub/v/android_alarm_manager_plus.svg)](https://pub.dev/packages/android_alarm_manager_plus) |
| [android_intent](./packages/android_intent/) | [![pub package](https://img.shields.io/pub/v/android_intent.svg)](https://pub.dev/packages/android_intent) | | android_intent_plus | [![pub package](https://img.shields.io/pub/v/android_intent_plus.svg)](https://pub.dev/packages/android_intent_plus) |
| [battery](./packages/battery/) | [![pub package](https://img.shields.io/pub/v/battery.svg)](https://pub.dev/packages/battery) | | battery_plus | [![pub package](https://img.shields.io/pub/v/battery_plus.svg)](https://pub.dev/packages/battery_plus) |
| [connectivity](./packages/connectivity/) | [![pub package](https://img.shields.io/pub/v/connectivity.svg)](https://pub.dev/packages/connectivity) | | connectivity_plus | [![pub package](https://img.shields.io/pub/v/connectivity_plus.svg)](https://pub.dev/packages/connectivity_plus) |
| [device_info](./packages/device_info/) | [![pub package](https://img.shields.io/pub/v/device_info.svg)](https://pub.dev/packages/device_info) | | device_info_plus | [![pub package](https://img.shields.io/pub/v/device_info_plus.svg)](https://pub.dev/packages/device_info_plus) |
| [package_info](./packages/package_info/) | [![pub package](https://img.shields.io/pub/v/package_info.svg)](https://pub.dev/packages/package_info) | | package_info_plus | [![pub package](https://img.shields.io/pub/v/package_info_plus.svg)](https://pub.dev/packages/package_info_plus) |
| [sensors](./packages/sensors/) | [![pub package](https://img.shields.io/pub/v/sensors.svg)](https://pub.dev/packages/sensors) | | sensors_plus | [![pub package](https://img.shields.io/pub/v/sensors_plus.svg)](https://pub.dev/packages/sensors_plus) |
| [share](./packages/share/) | [![pub package](https://img.shields.io/pub/v/share.svg)](https://pub.dev/packages/share) | | share_plus | [![pub package](https://img.shields.io/pub/v/share_plus.svg)](https://pub.dev/packages/share_plus) |
| [wifi_info_flutter](./packages/wifi_info_flutter/) | [![pub package](https://img.shields.io/pub/v/wifi_info_flutter.svg)](https://pub.dev/packages/wifi_info_flutter) | | network_info_plus | [![pub package](https://img.shields.io/pub/v/network_info_plus.svg)](https://pub.dev/packages/network_info_plus) |
Empty file.
66 changes: 0 additions & 66 deletions packages/android_alarm_manager/AUTHORS

This file was deleted.

Loading

0 comments on commit afc0ad2

Please sign in to comment.