feat(ci): Divide lint/docs and add linear-history and no-fixups #2737
Conversation
There was a problem hiding this comment.
The problem of removing the mergify label conditions is that these tests will become very noisy for PR authors (they'll get an email for CI test failure every time they push to a PR failing these checks). I'd recommend at least matching an extra condition of having an approval, but that makes it more complicated (see below).
Which brings me to the second issue: reusing the existing ci.yml workflow, and its triggers. The conditions for the new CI checks still rely on labels which can technically change anytime, not on pull request synchronization. And since I'm advocating a new condition on approval, we need a trigger for that too. I would recommend moving these tests to their own workflow file, with extra pull-request trigger types for label conditions (see agoric-sdk triggers), and look into also using a pull_request_review trigger?
These are CI workflow improvements.
I’ve copied no-fixups and linear-history from Agoric SDK, but removed their predicates on Mergify labels. We will simply see failures for these jobs for any change that is under review, so CI may have a couple failed jobs for otherwise ready changes.
I’ve also divided the lint job into separate lint and doc generation jobs in hopes that this takes some time off of CI. We should consolidate type checking so we do not duplicate effort for every package, but that remains a separate ambition.