Skip to content

go: dont override name from tag if tag name is empty #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredr merged 1 commit into from
Dec 11, 2025
Merged

go: dont override name from tag if tag name is empty #2199

fredr merged 1 commit into from
Dec 11, 2025

Conversation

@fredr
Copy link
Member

@fredr fredr commented Dec 11, 2025 •
edited
Loading

Fixes #2197

@fredr fredr self-assigned this Dec 11, 2025
@fredr fredr changed the title go: dont override name from tag in tag name is empty go: dont override name from tag if tag name is empty Dec 11, 2025
@encore-cla
Copy link

encore-cla bot commented Dec 11, 2025

All committers have signed the CLA.

@fredr fredr merged commit 695dcc6 into main Dec 11, 2025
5 checks passed
@fredr fredr deleted the fredr/go-empty-tag-name branch December 11, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eandre eandre eandre approved these changes

Assignees

@fredr fredr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

encore gen client --lang openapi generates empty property names if a struct fields json tag contains omitempty, but not the name

3 participants

@fredr @eandre