runtimes/js: add support for custom metrics #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
fredr
force-pushed
the
fredr/ts-custom-metrics
branch
2 times, most recently
from
72f6462 to
1efb0bd
Compare
eandre
reviewed
Nov 20, 2025
fredr
force-pushed
the
fredr/ts-metrics
branch
from
4189554 to
e914a67
Compare
fredr
force-pushed
the
fredr/ts-custom-metrics
branch
from
b59ebcb to
b24e057
Compare
eandre
previously approved these changes
Dec 11, 2025
Co-authored-by: André Eriksson <[email protected]>
Co-authored-by: André Eriksson <[email protected]>
fredr
force-pushed
the
fredr/ts-custom-metrics
branch
from
044fbdd to
2511f0f
Compare
eandre
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for creating custom metrics in typescript apps. Depends on #2109
Inspired by the implementation in the go runtime.
Metrics needs to be defined within a service, and will automatically add the service label.
This implementation is backed by a SharedArrayBuffer, where each u64 slot is a metric value, created from js by the main thread. From js we do atomic operation to update values on this buffer, and from rust we do atomic load when collecting the metrics. The rust runtime is use to coordinate what slot should be used for a label set, so that we can support multiple workers updating the same metric.