Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove imports from common submodule to other submodules #61

Merged

Conversation

eloy-encord
Copy link
Contributor

To remove imports from common submodule to other submodules the following change were applied:

  1. Remove build_embeddings() from EmbeddingDefinition (was importing model and dataset submodules)
  2. Remove build_embeddings() from Embeddings (was importing model and dataset submodules)
  3. Move Split enum to common submodule. This enum was imported from dataset and is also used in EmbeddingDefinition, so now it lives in common and is still accessible from the init of dataset as it is also core to this submodule (an import that is easy to remember and use).

As an extra, now Embeddings and EmbeddingsDefinition live in the same file as they don't mingle with other data types anymore and are "always" imported together.

@frederik-encord frederik-encord merged commit e85a63b into main Apr 22, 2024
1 check passed
@frederik-encord frederik-encord deleted the eloy/chore-remove-build-embeddings-from-definition branch April 22, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants