Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 4, 2026

It's that time of the year, let's update the license.

juwonjeong and others added 3 commits January 22, 2025 09:03
* WRQ-30515: Created component skeleton (#1650)

* Created component skeleton for ColorPickerPOC

* Added propTypes

* Fixed lint warnings

* WRQ-30516: [POC] Added Grid Color Picker (#1651)

* added color picker grid component

* added logic for new color picker grid component

* fixed story name

* adjueste component size

* fixed color array values

* updated cell size

* unified colorpickerpoc and colorpickergrid

* removed unwanted story

* lint fixes

* renamed util function

* WRQ-30515: Created component skeleton (#1653)

* Created component skeleton for ColorPickerPOC

* Added propTypes

* Fixed lint warnings

* Added option to remove favorite color on long press

* Applied design changes for the Favorite Colors section

* Added shake animation for delete action

* WRQ-30516: Optimized styling for grid color picker (#1654)

* added opposite color for focus on colorpickergrid

* added box shadow for focused color

* WRQ-30517: Slider type panel for the WebOS ColorPicker. (#1655)

* Added ColorPickerSlider functionality to ColorPickerPOC.

* Small fix for ColorPickerSlider.

* Transparent knob with border.

* Merge with main branch.

* Lint fix.

* Review fix.

* Review fix.

* WRQ-30519: [POC] webOS ColorPicker - spectrum color picker (#1656)

* *WIP* implement spectrum color picker

* added positionPointer, wrapped ColorPicker in Spottable, code cleanup

* fixed spottable div

* *WIP* added 5-way navigation to indicator

* color selection via 5-way, code cleanup, fix lint

* code review fixes

---------

Co-authored-by: Daniel Stoian <[email protected]>

* WRQ-30519: Added accelerator to spectrum color picker (#1659)

* *WIP* implement spectrum color picker

* added positionPointer, wrapped ColorPicker in Spottable, code cleanup

* fixed spottable div

* *WIP* added 5-way navigation to indicator

* color selection via 5-way, code cleanup, fix lint

* added accelerator to spectrum color picker

* fixed review issues

---------

Co-authored-by: Adrian Cocoara <[email protected]>
Co-authored-by: Daniel Stoian <[email protected]>

* WRQ-30515: Added handler to display colors state in actions log when favorite color is removed (#1660)

* Created component skeleton for ColorPickerPOC

* Added propTypes

* Fixed lint warnings

* Added option to remove favorite color on long press

* Applied design changes for the Favorite Colors section

* Added shake animation for delete action

* Added shake animation for delete action

* Added handler to display colors state in actions log when favorite color is removed

* Added pointer events

* Review fixes

* Changed alignment for favorite colors

* Fixed spotlight navigation on favorite colors

* fixed spectrum canvas size (#1662)

* WRQ-30517:  Create a slider type for webOS ColorPicker (part2) (#1661)

* Fixed problem with knob size and added a version of HSL for ColorPickerSlider.

* Small fix

* Review fixes

* WRQ-32413: [POC] webOS ColorPicker - add responsiveness (#1668)

* handle resize of canvas

* code cleanup

* sorted props

---------

Co-authored-by: Stanca <[email protected]>

* WRQ-32412: WebOS ColorPicker fixes and improvements (#1672)

* Added useEffect, so the sliders change when selecting a new color from favorites.

* Added a switch to chose between HSL or RGB format.

* Revert npm-shrinkwrap override

* style improvements

* spacing adjustments

---------

Co-authored-by: Stanca <[email protected]>

* WRQ-32437: Fixed deletion of favorite colors for ColorPicker (#1676)

* fixed deletion of favorite colors for ColorPicker

* save component state when props change

* removed unnecessary code

* added back useEffect

* changed outputText color to be more visible

* added handler for Enter key to edit favorite colors

* code review fix

---------

Co-authored-by: Stanca <[email protected]>

* WRR-1870: Adjust Slider ColorPicker based on feedback (#1684)

* Added a dropdown to chose between HSL or RGB format and an input for hex values.

* styling fixes

---------

Co-authored-by: Stanca <[email protected]>

* WRR-12000: Enhanced ColorPicker code and made component public (#1759)

* added JS Docs

* removed @module and indented code

* fixed JS docs

* fixed `too many doclets` error

* fixed js docs warning

* fixed JS docs

* fixed js docs

* added JD docs for SpectrumIndicator.js

* refactored rgbStringToHex function and added `willReadFrequently: true` parameter in ColorPickerSpectrum for optimization

* made ColorPicker main component public and ColorPickerGrid component props private

* fixed qa sampler

* removed forgotten console.log

* removed transform as it conflicted with 5-way navigation

* review fixes

* modified example in JS docs

* modified JS docs for ColorPicker example

* JS docs fix

* fixed JS docs

* added default colors

* fixed typo

* fixed JS docs

* changed slider names and adjusted tabLayout width

* updated deprecated max-width value

* moved max-width properties to target tabs class

* corrected selector

* fixed typo

* added `type` and `disabled` props

* changed type prop to public

* added disabled style and behavior for each subcomponent of ColorPicker

* added missing dependency

* review fixes

* added missing dependency

* review fix

* WRR-3979: Updated storybook to 8.4 (#1739)

* updated storybook to 8.4

* updated to latest storybook

* updated storybook-utils

* review fix

* dummy commit to fix cla license

* revert dummy commit

* removed spotlightDisabled from Dropdown as it is not recognized as a custom prop

* undo spotlightDisabled removal - warning has different cause

---------

Co-authored-by: Daniel Stoian <[email protected]>

* WRR-12002: ColorPicker - add unit/ui/ss tests (#1778)

* added JS Docs

* removed @module and indented code

* fixed JS docs

* fixed `too many doclets` error

* fixed js docs warning

* fixed JS docs

* fixed js docs

* added JD docs for SpectrumIndicator.js

* refactored rgbStringToHex function and added `willReadFrequently: true` parameter in ColorPickerSpectrum for optimization

* made ColorPicker main component public and ColorPickerGrid component props private

* fixed qa sampler

* removed forgotten console.log

* added unit tests for Grid and Sliders ColorPickers

* removed transform as it conflicted with 5-way navigation

* review fixes

* modified example in JS docs

* modified JS docs for ColorPicker example

* JS docs fix

* fixed JS docs

* *WIP* add ui tests for ColorPicker

* added default colors

* fixed typo

* fixed JS docs

* changed slider names and adjusted tabLayout width

* updated deprecated max-width value

* added ui tests for sliders color picker and one extra unit test

* moved max-width properties to target tabs class

* corrected selector

* fixed typo

* added screenshot tests for ColorPicker

* fix lint

* added `type` and `disabled` props

* changed type prop to public

* added unit tests for Spectrum

* added disabled style and behavior for each subcomponent of ColorPicker

* added missing dependency

* review fixes

* added missing dependency

* merge with WRR-12000 and update tests

* updated ui/ss tests

* review fix

* removed spotlightDisabled from Dropdown as it is not recognized as a custom prop

* added type to SliderColorPicker and extra unit tests

* added extra unit tests

* restore unit tests file

* added extra tests for FavoriteColors

* added utils unit tests and fix lint

* fix travis

* fix docs

* Update tests/ui/specs/ColorPicker/ColorPickerPage.js

* Apply suggestions from code review

* lint warning fixes

---------

Co-authored-by: Stanca <[email protected]>
Co-authored-by: Daniel Stoian <[email protected]>
Co-authored-by: Daniel Stoian <[email protected]>

* fix colorpicker's layout

* fixed slider know background-color on focus

* WRR-14756: Refactor ColorPicker to use `TabGroup` instead of `TabLayout` (#1801)

* refactor ColorPicker to use `TabGroup` instead of `TabLayout`

* fix lint

* layout fixes

* layout fixes

* layout fixes and minor refactoring

* updated ui-tests for the new layout

* added CSS variables

* add missing variables file

* fix import typo

* refactoring of css variables and styles

* added css variables and fixed failed unit tests

* minor fix in hex value

---------

Co-authored-by: Stanca <[email protected]>

* deleted unnecessary else block

* fix isomorphic tests

* fix isomorphic slice and fix layout

* fix isomorphic part 2

* removed JSDoc example

* WRR-18180: ColorPicker - fix live preview in docs (#1809)

* Added example back for ColorPicker

* Removed tabSize from ColorPicker

* Fixed a small problem with default props.

* Removed redundant useEffect to reduce the number of calls for onChangeColor.

* Small fix.

* fixed input width

* made ColorPicker component private and added its sampler in qa-stories

* removed ColorPickerSettingsApp component and its qa sampler

---------

Co-authored-by: ion-andrusciac-lgp <[email protected]>
Co-authored-by: Daniel Stoian <[email protected]>
Co-authored-by: alexandru-morariu-lgp <[email protected]>
Co-authored-by: Daniel Stoian <[email protected]>
Co-authored-by: paul-beldean-lgp <[email protected]>
Co-authored-by: Stanca <[email protected]>
Co-authored-by: taeyoung.hong <[email protected]>
Co-authored-by: Stanca <[email protected]>
Let's keep legal happy.
@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.82%. Comparing base (9200560) to head (ddeb5dd).

Files with missing lines Patch % Lines
ColorPicker/ColorPicker.js 74.35% 24 Missing and 6 partials ⚠️
ColorPicker/ColorPickerSpectrum.js 81.48% 15 Missing ⚠️
ColorPicker/SpectrumIndicator.js 77.61% 12 Missing and 3 partials ⚠️
ColorPicker/ColorPickerSlider.js 88.57% 4 Missing and 4 partials ⚠️
ColorPicker/utils.js 97.14% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
+ Coverage   72.47%   80.82%   +8.35%     
==========================================
  Files         148      152       +4     
  Lines        7498     7035     -463     
  Branches     2405     2084     -321     
==========================================
+ Hits         5434     5686     +252     
+ Misses       1566     1029     -537     
+ Partials      498      320     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants