fix merging of holds and rests in cycle #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- old impl returned mutated channel data which was not consumed - merge_rests impl should extend the last rest event - updated tests
|
Makes complete sense! I changed the naming in the loop to better reflect the fact that they are lists of events. I guess we can merge this and I'll rebase or merge my feature branch afterwards? My branch is one big feature away from completion but this fix is actually relevant there as well. |
|
Whatever is easier for you. Doesn't really make a difference here... |
|
Then I applied this fix to my branch, we can merge it with the rest later. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@unlessgames could you have a look please? Stumbled upon this while doing something else...