Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some euclidean issues & Use euclidean in cycle #15

Merged
merged 4 commits into from
May 22, 2024
Merged

Fix some euclidean issues & Use euclidean in cycle #15

merged 4 commits into from
May 22, 2024

Conversation

emuell
Copy link
Owner

@emuell emuell commented May 21, 2024

  • rotate arg now rotates left with positive values, right with negative values
  • handle some more corner cases like zero steps
  • added tests to verify that is behaves as expected (against the rhythm examples from the Toussaint paper)
  • replaced linear distribution with fixed euclid impl in cycle

emuell added 4 commits May 21, 2024 12:11
@emuell
fixed rotation in the eucliedean impl
bd3ebf8 
- cleaned up implementation
- added tests
@emuell
fixed rotation in lua euclidean pattern impl
5be2b6c 
- rotate left with positive offsets
- allow zero steps
- allow steps > length
@emuell
use euclidean in cycle
44850fc
@emuell
formatting
f03359a
@emuell emuell requested a review from unlessgames May 21, 2024 18:28
@unlessgames
Copy link
Collaborator

This can be merged now I think.

@emuell emuell merged commit 982dee3 into master May 22, 2024
1 check passed
@emuell emuell deleted the fix/euclidean branch May 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlessgames unlessgames unlessgames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emuell @unlessgames