Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of qlc in retainer #13025

Merged
merged 4 commits into from
May 16, 2024
Merged

Get rid of qlc in retainer #13025

merged 4 commits into from
May 16, 2024

Conversation

savonarola
Copy link
Contributor

@savonarola savonarola commented May 13, 2024 •
edited

Fixes EMQX-12367

Release version: v5.8.0/e5.8.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • [na] Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • [na] Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Schema changes are backward compatible

@savonarola savonarola marked this pull request as ready for review May 15, 2024 11:08
@savonarola savonarola requested review from lafirest and a team as code owners May 15, 2024 11:08
keynslug
keynslug previously approved these changes May 15, 2024
View reviewed changes
apps/emqx_utils/src/emqx_utils_stream.erl Outdated Show resolved Hide resolved
apps/emqx_utils/src/emqx_utils_stream.erl Outdated Show resolved Hide resolved
apps/emqx_retainer/src/emqx_retainer_mnesia.erl Outdated Show resolved Hide resolved
apps/emqx_retainer/src/emqx_retainer_mnesia.erl Show resolved Hide resolved
apps/emqx_retainer/src/emqx_retainer_mnesia.erl Outdated Show resolved Hide resolved
@savonarola savonarola force-pushed the 0513-fix-cursor-usage branch 4 times, most recently from 0ae0113 to 2f46d89 Compare May 15, 2024 17:32
thalesmg
thalesmg previously approved these changes May 15, 2024
View reviewed changes
apps/emqx_utils/test/emqx_utils_stream_tests.erl Outdated Show resolved Hide resolved
apps/emqx_retainer/src/emqx_retainer_mnesia.erl Outdated Show resolved Hide resolved
keynslug
keynslug previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@keynslug keynslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

apps/emqx_utils/src/emqx_utils_stream.erl Show resolved Hide resolved
zmstone
zmstone previously approved these changes May 16, 2024
View reviewed changes
thalesmg
thalesmg previously approved these changes May 16, 2024
View reviewed changes
@savonarola @thalesmg @zmstone
chore(retainer): scan table in batches, improve stream usage
1a664c9 
Co-authored-by: Thales Macedo Garitezi <[email protected]>
Co-authored-by: Zaiming (Stone) Shi <[email protected]>
@savonarola savonarola merged commit 22d5f17 into emqx:master May 16, 2024
168 checks passed
@savonarola savonarola deleted the 0513-fix-cursor-usage branch May 16, 2024 14:07
@savonarola savonarola mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

@zmstone zmstone zmstone left review comments

@keynslug keynslug keynslug left review comments

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@savonarola @zmstone @keynslug @thalesmg