Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(banned): verify delayed/taken over/retained messages against clientid_re ban rules #13006

Merged
merged 1 commit into from
May 16, 2024

Conversation

savonarola
Copy link
Contributor

@savonarola savonarola commented May 9, 2024

Fixes EMQX-12322

Release version: v/e5.8.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • [na] Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Schema changes are backward compatible

@savonarola savonarola changed the title fix(banned): verify delayed/will/retained messages against clientid_re rules fix(banned): verify delayed/taken over/retained messages against clientid_re rules May 9, 2024
@savonarola savonarola changed the title fix(banned): verify delayed/taken over/retained messages against clientid_re rules fix(banned): verify delayed/taken over/retained messages against clientid_re ban rules May 9, 2024
@savonarola savonarola marked this pull request as ready for review May 9, 2024 21:01
@savonarola savonarola requested review from lafirest and a team as code owners May 9, 2024 21:01
@savonarola savonarola force-pushed the 0509-fix-retainer-banned branch 2 times, most recently from 4f2483f to 505acb0 Compare May 10, 2024 16:06
changes/ce/fix-13006.en.md Outdated Show resolved Hide resolved
zmstone
zmstone previously approved these changes May 12, 2024
@savonarola savonarola merged commit 1f7e358 into emqx:master May 16, 2024
171 checks passed
@savonarola savonarola deleted the 0509-fix-retainer-banned branch May 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants