Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(script): add script page #1851

Open
wants to merge 11 commits into
base: dev/2.0.0
Choose a base branch
from
Open

feat(script): add script page #1851

wants to merge 11 commits into from

Conversation

Red-Asuka
Copy link
Member

@Red-Asuka Red-Asuka commented Jan 3, 2025

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

  • The web version does not support custom functions.
  • Custom functions and schemas share the same table and components.
  • The parameter types for custom functions are confusing.

What is the new behavior?

  • Replaced VM2 with UVM to enable running custom functions directly in the browser, allowing web support for custom functions.
  • Separated custom functions from schemas, using different tables for storage to simplify logic.
  • Enhanced custom function editing capabilities:
    • Added empty function name check.
    • Enabled auto-focus on input fields when the popup opens.
    • Improved error logic for other scenarios.
    • Provided duplicate name alerts to avoid conflicts.
    • Optimized file input for easy editing and renaming when importing functions.
  • Improved custom function parameter types, removing hidden conversions when sending JSON data.
  • Enhanced custom function testing to support additional format conversions.
image

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka self-assigned this Jan 3, 2025
@Red-Asuka Red-Asuka added refactor Refactor code or architecture web MQTTX Web desktop MQTTX Desktop labels Jan 8, 2025
@Red-Asuka Red-Asuka added this to the v2.0.0-alpha.1 milestone Jan 8, 2025
@Red-Asuka Red-Asuka marked this pull request as ready for review January 8, 2025 03:38
@Red-Asuka Red-Asuka requested a review from ysfscream January 8, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop refactor Refactor code or architecture web MQTTX Web
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant