Make CDN optional & minor code improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in core), minor code style fixes, fixed editor overlay for default/default admin theme, add tailwind css only if active, remove dependency from cdn
|
Wow, there are a lot of changes! Thanks for your contribution, but maybe it's better to split them into single PRs. Please give me time to review and test all. |
| @@ -0,0 +1,3 @@ | |||
| .hor-scroll { | |||
| overflow: initial; | |||
| } | |||
There was a problem hiding this comment.
What problem does this solve? I have tried it with the default theme and I did not encounter any issues even without this CSS.
There was a problem hiding this comment.
Without this fix it may look like this:
|
By deleting workers in js/monacoeditor folder, Tailwind IntelliSense does not work. |
…ripts as this causes problems with tailwind workers
Yeah you're right, this was not very clever🤦♂️ I re-added the deleted files and removed JavaScript deferring because that also caused issues with Tailwind Autocompletion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great idea to integrate the Monaco Editor in Magento/OpenMage 😍
This PR suggests several improvements:
composer.jsonfilepackage.jsonmm_monacoeditor/system_config_source_cms_pageswith model from coredeferred JavaScriptsHope you like it. Looking forward to your feedback!