Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS Animations for entry and exit animations #354

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented May 18, 2024

This PR adds the use of CSS animations for Vaul entry and exit animations, making the code for managing the open state simpler.

I also refactored the logic of the scaleBackground function by changing

  • Taking advantage of the Content component to be mounted/unmounted when the dialog is open or closed
  • Created two utility functions assignStyle and chain that together facilitate the editing of styles and their cleaning

Fixes #292

Copy link

vercel bot commented May 18, 2024

@joaom00 is attempting to deploy a commit to the emil Team on Vercel.

A member of the Team first needs to authorize it.

@rortan134
Copy link
Contributor

Also closes #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward the defaultOpen prop
2 participants