Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates toast action/cancel property type/handlers #398

Merged
merged 3 commits into from May 23, 2024
Merged

feat: updates toast action/cancel property type/handlers #398

merged 3 commits into from May 23, 2024

Conversation

6thpath
Copy link
Contributor

@6thpath 6thpath commented Apr 6, 2024

Issue:

Closes #397

What has been done:

  • Changes Action.label type to React.ReactNode
  • Removes required function check on isAction helper
  • Handles action/cancel optional onClick property

Screenshots/Videos:

N/A

@vercel Vercel
Copy link

vercel bot commented Apr 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 9:04am

@emilkowalski emilkowalski merged commit 7d28d42 into emilkowalski:main May 23, 2024
2 checks passed
@emilkowalski emilkowalski mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve capability of toast action/cancel customization
2 participants
@6thpath @emilkowalski