Gradient line support #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moves the `style_line` to receive a `PathStroke` instead of just a `Stroke` value to take advantage of the `UV` `ColorMode`.
emilk
approved these changes
Apr 3, 2025
… and made gradient fill checkbox disabled when gradient line is not selected. These address code review feedback
emilk
added
enhancement
|
@sapessi could you please update the branch and fix the tests? |
|
Apologies for the delay. Looking into it. Seems like the images it's comparing against are corrupted in my repo. Probably something I'm doing wrong with git-lfs. |
|
Good to merge? |
|
Looks like in the meanwhile someone else merged a new commit that brakes the tests. I'll wait for someone to pick this up again before I work to resolve the conflicts because it's been waiting, conflict-free for a month. |
|
for me - yes |
|
I can't see any changes to the images in the main branch. I'm going to keep the images from this branch that include the new checkboxes |
|
Can we merge, @emilk? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Mac the test_demos, test_light_mode, and test_scalestests were failing with a
FormatErrorsayingInvalidSignature.git-lfsis installed and the error suggests reading how to set up things in theCONTRIBUTINGguidelines but there was nothing there aboutgit-lfs.