Bump Rust Version and fix Plot Item Visibility in Demo #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to update the Rust toolchain version and improve code consistency and tooling. The most important updates include upgrading Rust from version 1.81 to 1.84 across the project, enhancing the
settings.json
for better development experience, and refactoring lifetimes in trait implementations for improved simplicity.Rust version upgrade:
1.81
to1.84
in.github/workflows/rust.yml
,Cargo.toml
,rust-toolchain
, andscripts/check.sh
to ensure compatibility with the latest features and improvements. [1] [2] [3] [4]msrv
(Minimum Supported Rust Version) inclippy.toml
andscripts/clippy_wasm/clippy.toml
to align with the new Rust version. [1] [2]Development tooling enhancements:
.vscode/settings.json
to enforce consistent formatting (formatOnSave
,trimTrailingWhitespace
,insertFinalNewline
) and improve Rust Analyzer behavior with custom target directories and semantic token customizations.Code refactoring:
'a
) with implicit lifetimes ('_
) inegui_plot/src/items/mod.rs
,egui_plot/src/items/values.rs
, andegui_plot/src/lib.rs
. This reduces verbosity and improves readability. [1] [2] [3] [4] [5] [6] [7]Minor improvements:
id
to markers indemo/src/plot_demo.rs
to prevent potential conflicts during rendering.map_or
withis_some_and
for better clarity in linked cursor checks inegui_plot/src/lib.rs
.Documentation updates:
Improved formatting and structure of the
README.md
for better readability, including converting links to angle-bracket syntax and reorganizing sections.Closes Toggling plot item visibility via legend is broken #99
Closes PlotItemBase is unresolved when trying to implement trait PlotItem #101
I have followed the instructions in the PR template