Skip to content

Bump Rust Version and fix Plot Item Visibility in Demo #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2025

Conversation

bircni
Copy link
Contributor

@bircni bircni commented May 4, 2025

This pull request includes multiple changes to update the Rust toolchain version and improve code consistency and tooling. The most important updates include upgrading Rust from version 1.81 to 1.84 across the project, enhancing the settings.json for better development experience, and refactoring lifetimes in trait implementations for improved simplicity.

Rust version upgrade:

  • Updated Rust toolchain version from 1.81 to 1.84 in .github/workflows/rust.yml, Cargo.toml, rust-toolchain, and scripts/check.sh to ensure compatibility with the latest features and improvements. [1] [2] [3] [4]
  • Updated the msrv (Minimum Supported Rust Version) in clippy.toml and scripts/clippy_wasm/clippy.toml to align with the new Rust version. [1] [2]

Development tooling enhancements:

  • Added new settings in .vscode/settings.json to enforce consistent formatting (formatOnSave, trimTrailingWhitespace, insertFinalNewline) and improve Rust Analyzer behavior with custom target directories and semantic token customizations.

Code refactoring:

  • Simplified lifetime annotations in trait implementations by replacing explicit lifetimes (e.g., 'a) with implicit lifetimes ('_) in egui_plot/src/items/mod.rs, egui_plot/src/items/values.rs, and egui_plot/src/lib.rs. This reduces verbosity and improves readability. [1] [2] [3] [4] [5] [6] [7]

Minor improvements:

  • Added unique id to markers in demo/src/plot_demo.rs to prevent potential conflicts during rendering.
  • Replaced map_or with is_some_and for better clarity in linked cursor checks in egui_plot/src/lib.rs.

Documentation updates:

@bircni bircni changed the title Patch99 Bump Rust Version and fix Plot Item Visibility in Demo May 4, 2025
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thank you!

@emilk emilk added the include in changelog This change will be included in the changelog label Jun 16, 2025
@emilk emilk merged commit 5322223 into emilk:main Jun 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog This change will be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlotItemBase is unresolved when trying to implement trait PlotItem Toggling plot item visibility via legend is broken
2 participants