Allow x/y only zooming by click-dragging respective axis (#17) #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bircni
reviewed
Apr 27, 2025
| @@ -388,6 +390,16 @@ impl<'a> Plot<'a> { | |||
| self | |||
| } | |||
|
|
|||
| /// Whether to allow dragging in the axis areas to automaticall zoom the plot. Default: `true`. | |||
There was a problem hiding this comment.
Should we really have this true as default?
There was a problem hiding this comment.
I don't really mind. I'll change this to false.
Would you also like me to change the demo app to include options to toggle this behaviour on and off?
There was a problem hiding this comment.
Done!
Repushed to my branch and updated this PR to e031001
|
Is there anything else I can do to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-04-25.at.20.58.23.mov